GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||
GeezerVison is showing github.com — bpo-41712: Vulnerable regex changed by Pixmew · Pull Request #23166 · python/cpython Conversation
|
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
should work
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Hello, thanks for your first PR to CPython. I'm not a core dev but I'll do my best to try address some of this.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
…kdm.rst Co-authored-by: kj <[email protected]>
Co-authored-by: kj <[email protected]>
There was an error while loading. Please reload this page.
|
Thank you Sir for your suggestions it helped me a lot. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
sorry i accendenttly removed reviewer what should i do |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Sir what is core review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@Fidget-Spinner Sir can you please review the PR #23191 Thnakyou sir |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Sorry, I don't think you should open multiple PRs because it makes it harder to track the development of a solution. Maybe reopen this one and close the other? (I don't see any difference between the two anyways) I'm not a core developer. The These things take time - a core developer may take up to a month, or maybe even longer to take a look at your PR. So I recommend exercising patience. The core devs are mostly doing this out of their own free time. If nobody looks at your PR after maybe 2 - 4 weeks, you can comment on the bugs.python.org issue and ask for a PR. Edit: BTW you don't have to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thankyou sir but it dosent say requested review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
What do you think i should do |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Yes. Also I'd recommend this:
The request for review isn't required. They can review it even without that. Pinging @zooba for this, sorry for the noise generated. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ok Sir Thankyou. You have been are very Kind and helpfull. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for the contribution! This doesn't need a NEWS entry, so I added the tag and removed the file (I'm worried it may concern people who read updates, because it mentions a vulnerability that they were never vulnerable to). Once CI clears, I'll merge it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
For future contributions, you may also want to work from a branch in your repository, rather than |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks you Sir |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
No problems at all. There is no product impact from this change, so it doesn't need to be listed in the product changes :) Copying the title of the original bug is fine, though in this case we quickly determined that the title was inaccurate (but never changed it). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.