GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-42374: Allow unparenthesized walrus in genexps (GH-23319) by lysnikolaou · Pull Request #23329 · python/cpython

Conversation

@lysnikolaou

@lysnikolaou lysnikolaou commented Nov 16, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This fixes a regression that was introduced by the new parser.

(cherry picked from commit cb3e5ed)

https://bugs.python.org/issue42374

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lysnikolaou
bpo-42374: Allow unparenthesized walrus in genexps (pythonGH-23319)
5244e21 
This fixes a regression that was introduced by the new parser.

(cherry picked from commit cb3e5ed)
@lysnikolaou
lysnikolaou requested a review from pablogsal as a code owner November 16, 2020 23:14
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 16, 2020
@bedevere-bot bedevere-bot mentioned this pull request Nov 16, 2020
bpo-42374: Allow unparenthesized walrus in genexps #23319
Merged
@bedevere-bot bedevere-bot added the awaiting core review label Nov 16, 2020
@lysnikolaou
lysnikolaou merged commit 2b800ef into python:3.9 Nov 16, 2020
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 16, 2020
@lysnikolaou
lysnikolaou deleted the backport-cb3e5ed-3.9 branch November 16, 2020 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@lysnikolaou @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.