GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42374: Allow unparenthesized walrus in genexps by lysnikolaou · Pull Request #23319 · python/cpython

Conversation

@lysnikolaou

@lysnikolaou lysnikolaou commented Nov 16, 2020 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This fixes a regression that was introduced by the new parser.

https://bugs.python.org/issue42374

Automerge-Triggered-By: GH:lysnikolaou

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lysnikolaou
bpo-42374: Allow unparenthesized walrus in genexps
1f188e4 
This fixes a regression that was introduced by the new parser.
@lysnikolaou
lysnikolaou requested a review from pablogsal as a code owner November 16, 2020 17:54
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 16, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Nov 16, 2020
@lysnikolaou
lysnikolaou requested review from gvanrossum and terryjreedy November 16, 2020 17:54
@lysnikolaou lysnikolaou added the needs backport to 3.9 label Nov 16, 2020
@blurb-it
📜🤖 Added by blurb_it.
3445022
pablogsal
pablogsal approved these changes Nov 16, 2020
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 🎣

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 16, 2020
pablogsal
pablogsal reviewed Nov 16, 2020
View reviewed changes
Comment thread Lib/test/test_named_expressions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Nov 16, 2020

Copy link
Copy Markdown
Member

How did you find this? 🤔
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lysnikolaou

lysnikolaou commented Nov 16, 2020

Copy link
Copy Markdown
Member Author

How did you find this?

@terryjreedy found it while working on #23291.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lysnikolaou
Change assertion
49d61d5
@lysnikolaou lysnikolaou added the 🤖 automerge label Nov 16, 2020
@miss-islington

miss-islington commented Nov 16, 2020

Copy link
Copy Markdown
Contributor

@lysnikolaou: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit cb3e5ed into python:master Nov 16, 2020
@miss-islington

miss-islington commented Nov 16, 2020

Copy link
Copy Markdown
Contributor

Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 16, 2020
@miss-islington

miss-islington commented Nov 16, 2020

Copy link
Copy Markdown
Contributor

Sorry, @lysnikolaou, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker cb3e5ed0716114393696ec7201e51fe0595eab4f 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington self-assigned this Nov 16, 2020
@lysnikolaou
lysnikolaou deleted the unparenthesized-walrus-genexp branch November 16, 2020 23:09
lysnikolaou added a commit to lysnikolaou/cpython that referenced this pull request Nov 16, 2020
@lysnikolaou
bpo-42374: Allow unparenthesized walrus in genexps (pythonGH-23319)
5244e21 
This fixes a regression that was introduced by the new parser.

(cherry picked from commit cb3e5ed)
@bedevere-bot

bedevere-bot commented Nov 16, 2020

Copy link
Copy Markdown

GH-23329 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Nov 16, 2020
@lysnikolaou lysnikolaou mentioned this pull request Nov 16, 2020
gh-86482: Document assignment expression need for ()s #23291
Merged
lysnikolaou added a commit that referenced this pull request Nov 16, 2020
@lysnikolaou
bpo-42374: Allow unparenthesized walrus in genexps (GH-23319) (GH-23329)
2b800ef 
This fixes a regression that was introduced by the new parser.

(cherry picked from commit cb3e5ed)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@lysnikolaou @adorilson
bpo-42374: Allow unparenthesized walrus in genexps (pythonGH-23319)
69434fb 
This fixes a regression that was introduced by the new parser.

Automerge-Triggered-By: GH:lysnikolaou
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@terryjreedy terryjreedy Awaiting requested review from terryjreedy
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@miss-islington miss-islington

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@lysnikolaou @pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.