GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41861: Add NEWS and normalise _sqlite3 Cache/Node type struct naming by erlend-aasland · Pull Request #23337 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Nov 17, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue41861

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland added 2 commits November 17, 2020 11:04
Erlend E. Aasland
Normalize Cache/Node type struct naming
844f27b
Erlend E. Aasland
Add NEWS
b895505
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner November 17, 2020 10:11
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 17, 2020
@bedevere-bot bedevere-bot added the awaiting review label Nov 17, 2020
@erlend-aasland

erlend-aasland commented Nov 17, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@corona10 Would you mind taking a quick look at this? Just closing bpo-41861 by adding a NEWS entry and normalising Cache/Node struct names (so that the naming is consistent with the other type structs in _sqlite3.)

(I closed #22419, since it went in limbo.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10
corona10 reviewed Nov 17, 2020
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlend-aasland

Can you provide a discussion about normalizing?
we often do not accept this kind of PR ;)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland

erlend-aasland commented Nov 17, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Can you provide a discussion about normalizing?
we often do not accept this kind of PR ;)

Yes, I'm aware of that, but since this is the final PR of bpo-41861, I thought an exception would be acceptable, since the other PR's relating to this bpo have used this naming scheme ;) Please? :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Nov 17, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2020-10-01-15-44-52.bpo-41861.YTqJ7z.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend Egeberg Aasland @vstinner
Fix punctuation mark in NEWS entry
f268153 
Co-authored-by: Victor Stinner <[email protected]>
@vstinner
vstinner merged commit 2ffba2a into python:master Nov 17, 2020
@bedevere-bot bedevere-bot removed the awaiting review label Nov 17, 2020
@vstinner

vstinner commented Nov 17, 2020

Copy link
Copy Markdown
Member

Merged. I rewrote your commit message to make it shorter.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland deleted the bpo-41861/final branch November 17, 2020 13:32
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland @adorilson
bpo-41861, _sqlite3 : Add NEWS entry and rename variables (pythonGH-2…
b989296 
…3337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@corona10 corona10 corona10 left review comments
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @vstinner @corona10 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.