GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-1635741: Port _queue to multiphase initialization by tiran · Pull Request #23376 · python/cpython

Conversation

tiran commented Nov 18, 2020 •

edited by miss-islington

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue1635741

Automerge-Triggered-By: GH:tiran

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tiran requested a review from rhettinger as a code owner

November 18, 2020 19:12

the-knights-who-say-ni added the CLA signed label

Nov 18, 2020

bedevere-bot added the awaiting core review label

Nov 18, 2020

tiran requested review from corona10 and vstinner

November 18, 2020 23:38

vstinner approved these changes

Nov 19, 2020

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suggest to use PyModule_AddObjectRef() to make the code even better :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tiran reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

Modules/_queuemodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting merge and removed awaiting core review labels

Nov 19, 2020

tiran added 2 commits

November 19, 2020 08:49


          bpo-1635741: Port _queue to multiphase initialization

7a6dea1

Signed-off-by: Christian Heimes <[email protected]>


          Use PyModule_AddObjectRef

c620a61

tiran force-pushed the bpo-1635741-queue branch from 526b05a to c620a61 Compare

November 19, 2020 07:51

tiran requested a review from vstinner

November 19, 2020 07:52

vstinner approved these changes

Nov 19, 2020

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Modules/_queuemodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

tiran added the 🤖 automerge label

Nov 19, 2020

miss-islington commented Nov 19, 2020

Copy link

Copy Markdown

Contributor

@tiran: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington merged commit 3094dd5 into python:master

Nov 19, 2020

bedevere-bot removed the awaiting merge label

Nov 19, 2020

bedevere-bot commented Nov 19, 2020

Copy link

Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Shared 3.x has failed when building commit 3094dd5.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/483/builds/403) and take a look at the build logs.
Check if the failure is related to this commit (3094dd5) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/483/builds/403

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

404 tests OK.

10 slowest tests:

test_cmd_line: 4 min 40 sec
test_concurrent_futures: 4 min 15 sec
test_multiprocessing_spawn: 2 min 38 sec
test_unparse: 2 min 37 sec
test_tokenize: 2 min 35 sec
test_multiprocessing_forkserver: 2 min 25 sec
test_asyncio: 1 min 39 sec
test_capi: 1 min 37 sec
test_multiprocessing_fork: 1 min 35 sec
test_subprocess: 1 min 32 sec

1 test altered the execution environment:
test_concurrent_futures

20 tests skipped:
test_dbm_gnu test_devpoll test_epoll test_gdb test_idle test_ioctl
test_msilib test_ossaudiodev test_spwd test_startfile test_tcl
test_tix test_tk test_ttk_guionly test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 14 min 1 sec

Click to see traceback logs

Traceback (most recent call last):
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "<string>", line 1, in <module>
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/spawn.py", line 116, in spawn_main
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/spawn.py", line 116, in spawn_main
    exitcode = _main(fd, parent_sentinel)
    exitcode = _main(fd, parent_sentinel)
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/spawn.py", line 126, in _main
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/spawn.py", line 126, in _main
    self = reduction.pickle.load(from_parent)
    self = reduction.pickle.load(from_parent)
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/synchronize.py", line 110, in __setstate__
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/synchronize.py", line 110, in __setstate__
    self._semlock = _multiprocessing.SemLock._rebuild(*state)
    self._semlock = _multiprocessing.SemLock._rebuild(*state)
FileNotFoundError: [Errno 2] No such file or directory
FileNotFoundError: [Errno 2] No such file or directory
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/spawn.py", line 116, in spawn_main
    exitcode = _main(fd, parent_sentinel)
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/spawn.py", line 126, in _main
    self = reduction.pickle.load(from_parent)
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/synchronize.py", line 110, in __setstate__
    self._semlock = _multiprocessing.SemLock._rebuild(*state)
FileNotFoundError: [Errno 2] No such file or directory
Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 2)
Warning -- Dangling thread: <Thread(QueueFeederThread, started daemon 34420633600)>
Warning -- Dangling thread: <_MainThread(MainThread, started 34374492160)>
Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 2)
Warning -- Dangling thread: <_MainThread(MainThread, started 34374492160)>
Warning -- Dangling thread: <Thread(QueueFeederThread, started daemon 34420633600)>
/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: There appear to be 3 leaked semaphore objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
Warning -- Unraisable exception
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/util.py", line 224, in __call__
    res = self._callback(*self._args, **self._kwargs)
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/synchronize.py", line 87, in _cleanup
    sem_unlink(name)
FileNotFoundError: [Errno 2] No such file or directory
Warning -- Unraisable exception
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/util.py", line 224, in __call__
    res = self._callback(*self._args, **self._kwargs)
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/synchronize.py", line 87, in _cleanup
    sem_unlink(name)
FileNotFoundError: [Errno 2] No such file or directory
Warning -- Unraisable exception
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/util.py", line 224, in __call__
    res = self._callback(*self._args, **self._kwargs)
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/synchronize.py", line 87, in _cleanup
    sem_unlink(name)
FileNotFoundError: [Errno 2] No such file or directory

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

adorilson pushed a commit to adorilson/cpython that referenced this pull request

Mar 13, 2021


          bpo-1635741: Port _queue to multiphase initialization (pythonGH-23376)

1bc7281

Signed-off-by: Christian Heimes <[email protected]>

Automerge-Triggered-By: GH:tiran

kylotan mannequin mentioned this pull request

Sep 19, 2022

Py_Finalize() doesn't clear all Python objects at exit #44470

Closed

Moosems mentioned this pull request

Aug 21, 2024

Creating multiprocessing.Queues operates strangely with Process's created in classes #123208

Open

Reviewers

vstinner

vstinner approved these changes

rhettinger

Awaiting requested review from rhettinger

corona10

Awaiting requested review from corona10

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

tiran commented Nov 18, 2020 • edited by miss-islington Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington commented Nov 19, 2020

Uh oh!

bedevere-bot commented Nov 19, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tiran commented Nov 18, 2020 •

edited by miss-islington

Loading

Uh oh!

There was an error while loading. Please reload this page.