GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Convert _imp to multi-phase init by vstinner · Pull Request #23378 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Nov 18, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Convert the _imp extension module to the multi-phase initialization
API (PEP 489).

  • Add _PyImport_BootstrapImp() which fix a bootstrap issue: import
    the _imp module before importlib is initialized.
  • Add create_builtin() sub-function, used by _imp_create_builtin().
  • Initialize PyInterpreterState.import_func earlier, in
    pycore_init_builtins().
  • Remove references to _PyImport_Cleanup(). This fnuction has been
    renamed to finalize_modules() and moved to pylifecycle.c.

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
vstinner requested review from brettcannon, encukou, ericsnowcurrently, ncoghlan and warsaw as code owners November 18, 2020 21:10
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 18, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Nov 18, 2020
@vstinner vstinner added the skip news label Nov 18, 2020
@vstinner
bpo-1635741: Convert _imp to multi-phase init
7b583cc
Convert the _imp extension module to the multi-phase initialization
API (PEP 489).

* Add _PyImport_BootstrapImp() which fix a bootstrap issue: import
  the _imp module before importlib is initialized.
* Add create_builtin() sub-function, used by _imp_create_builtin().
* Initialize PyInterpreterState.import_func earlier, in
  pycore_init_builtins().
* Remove references to _PyImport_Cleanup(). This fnuction has been
  renamed to finalize_modules() and moved to pylifecycle.c.
@vstinner
vstinner merged commit 6223071 into python:master Nov 18, 2020
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 18, 2020
@vstinner
vstinner deleted the imp_multiphase branch November 18, 2020 22:18
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@vstinner @adorilson
bpo-1635741: Convert _imp to multi-phase init (pythonGH-23378)
61e8759
Convert the _imp extension module to the multi-phase initialization
API (PEP 489).

* Add _PyImport_BootstrapImp() which fix a bootstrap issue: import
  the _imp module before importlib is initialized.
* Add create_builtin() sub-function, used by _imp_create_builtin().
* Initialize PyInterpreterState.import_func earlier, in
  pycore_init_builtins().
* Remove references to _PyImport_Cleanup(). This function has been
  renamed to finalize_modules() and moved to pylifecycle.c.
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
@ericsnowcurrently ericsnowcurrently mentioned this pull request Oct 19, 2022
create_builtin() in _imp module trigger segfault if taking a builtin object as input #98354
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon
@encukou encukou Awaiting requested review from encukou
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently
@ncoghlan ncoghlan Awaiting requested review from ncoghlan
@warsaw warsaw Awaiting requested review from warsaw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.