GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Port _random to the multi-phase init by vstinner · Pull Request #23381 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Nov 18, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Port the _random extension module to the multi-phase initialization
API (PEP 489).

  • Create Random_Type using PyType_FromModuleAndSpec().
  • Add get_random_state_from_type() function. It replaces the removed
    _randomstate_global macro.

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-1635741: Port _random to the multi-phase init
d1b4755 
Port the _random extension module to the multi-phase initialization
API (PEP 489).

* Create Random_Type using PyType_FromModuleAndSpec().
* Add get_random_state_from_type() function. It replaces the removed
  _randomstate_global macro.
@vstinner
vstinner requested a review from rhettinger as a code owner November 18, 2020 23:12
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 18, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Nov 18, 2020
@vstinner

vstinner commented Nov 18, 2020

Copy link
Copy Markdown
Member Author

@corona10 @shihai1991: Would you mind to review my PR? Especially the new get_random_state_from_type() function.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran

tiran commented Nov 18, 2020

Copy link
Copy Markdown
Member

This PR is a duplicate of #23359
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Nov 19, 2020

Copy link
Copy Markdown
Member Author

This PR is a duplicate of #23359

Oh, I missed your PR. I abandon mine and approved yours.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Nov 19, 2020
@vstinner
vstinner deleted the random_multiphase branch November 19, 2020 07:44
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @tiran @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.