GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Port _random to multiphase initialization by tiran · Pull Request #23359 · python/cpython

Conversation

@tiran

@tiran tiran commented Nov 18, 2020 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue1635741

Automerge-Triggered-By: GH:tiran

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
bpo-1635741: Port _random to multiphase initialization
041b28a 
Signed-off-by: Christian Heimes <[email protected]>
@tiran
tiran requested a review from rhettinger as a code owner November 18, 2020 08:18
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 18, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Nov 18, 2020
@tiran tiran mentioned this pull request Nov 18, 2020
bpo-1635741: Port _random to the multi-phase init #23381
Closed
@tiran
tiran requested review from corona10 and vstinner November 18, 2020 23:37
vstinner
vstinner approved these changes Nov 19, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, perfect!

It's impressive that I wrote almost exactly the same PR!? :-D (PR #23381).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tiran reacted with laugh emoji tiran reacted with hooray emoji
All reactions
  • 😄 1 reaction
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 19, 2020
@tiran tiran added the 🤖 automerge label Nov 19, 2020
@miss-islington
miss-islington merged commit cc0cd43 into python:master Nov 19, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 19, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@tiran @adorilson
bpo-1635741: Port _random to multiphase initialization (pythonGH-23359)
4f3a280 
Signed-off-by: Christian Heimes <[email protected]>
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger
@corona10 corona10 Awaiting requested review from corona10

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@tiran @vstinner @the-knights-who-say-ni @bedevere-bot @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.