GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Fix _struct for build bot error by corona10 · Pull Request #23402 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Nov 19, 2020 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue1635741

Automerge-Triggered-By: GH:tiran

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
bpo-1635741: Fix _struct for build bot error
2b44fc9
@corona10
corona10 requested a review from tiran November 19, 2020 13:52
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 19, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Nov 19, 2020
@corona10 corona10 added the skip news label Nov 19, 2020
tiran
tiran approved these changes Nov 19, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 19, 2020
@tiran

tiran commented Nov 19, 2020

Copy link
Copy Markdown
Member

Thanks, you were faster than me.
corona10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran added the 🤖 automerge label Nov 19, 2020
@corona10

corona10 commented Nov 19, 2020

Copy link
Copy Markdown
Member Author

@tiran I was panicked at the first time ;)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Nov 19, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Ah, it seems like only big endian architectures are affected, that's why the typo was not spotted by CIs run on the merged PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@miss-islington

miss-islington commented Nov 19, 2020

Copy link
Copy Markdown
Contributor

@corona10: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 588c7c9 into python:master Nov 19, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 19, 2020
@corona10
corona10 deleted the gh-23398-fix branch November 19, 2020 14:15
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@corona10 @adorilson
bpo-1635741: Fix _struct for build bot error (pythonGH-23402)
dfd7d1c 
Automerge-Triggered-By: GH:tiran
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
+1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@corona10 @tiran @miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.