GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-42299: Remove formatter module by corona10 · Pull Request #23476 · python/cpython

Conversation

corona10 commented Nov 23, 2020 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

https://bugs.python.org/issue42299

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

corona10 requested a review from terryjreedy

November 23, 2020 14:46

the-knights-who-say-ni added the CLA signed label

Nov 23, 2020

bedevere-bot added the awaiting core review label

Nov 23, 2020


          bpo-42299: Remove formatter module

08e2c99

corona10 force-pushed the bpo-42299 branch from 9aac4ab to 08e2c99 Compare

November 23, 2020 14:48


          bpo-42299: Update docs

ea3bf79

vstinner reviewed

Nov 24, 2020

View reviewed changes

Comment thread

Doc/whatsnew/3.10.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Misc/NEWS.d/next/Library/2020-11-23-23-42-08.bpo-42299.Fdn4Wf.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Misc/NEWS.d/next/Library/2020-11-23-23-42-08.bpo-42299.Fdn4Wf.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

vstinner reviewed

Nov 24, 2020

View reviewed changes

Comment thread

Misc/NEWS.d/next/Library/2020-11-23-23-42-08.bpo-42299.Fdn4Wf.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          bpo-42299: Apply code review

16d394a

corona10 requested a review from vstinner

November 24, 2020 14:21

corona10 commented

Nov 24, 2020

View reviewed changes

corona10 left a comment

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner Can you please take a look?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner reviewed

Nov 24, 2020

View reviewed changes

Comment thread

Doc/whatsnew/3.10.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/whatsnew/3.10.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

vstinner approved these changes

Nov 24, 2020

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm fine with removing the module. I just left minor remarks on the documentation, you're free to ignore them.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting core review labels

Nov 24, 2020

terryjreedy reviewed

Nov 24, 2020

View reviewed changes

terryjreedy left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I simply don't know if anything else is needed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/whatsnew/3.10.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

terryjreedy requested changes

Nov 24, 2020

View reviewed changes

terryjreedy left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggested change, which applies to news also.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting changes and removed awaiting merge labels

Nov 24, 2020

bedevere-bot commented Nov 24, 2020

Copy link

Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Update Doc/whatsnew/3.10.rst

60ec82a

Co-authored-by: Terry Jan Reedy <[email protected]>

vstinner approved these changes

Nov 25, 2020

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @terryjreedy for the way better documentation than what I wrote :-) It's good to write down the full rationale, otherwise people get angry when they see that we remove modules on purpose.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

corona10 reacted with thumbs up emoji

All reactions

👍 1 reaction

bedevere-bot added awaiting merge and removed awaiting changes labels

Nov 25, 2020


          bpo-42299: Update NEWS.d

783ae4c

corona10 force-pushed the bpo-42299 branch from 73d6f86 to 783ae4c Compare

November 25, 2020 12:53

corona10 commented Nov 25, 2020

Copy link

Copy Markdown

Member Author

@vstinner @terryjreedy
Thanks Victor,
I will merge this PR after CI is passed ;)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

corona10 merged commit be319c0 into python:master

Nov 25, 2020

bedevere-bot removed the awaiting merge label

Nov 25, 2020

corona10 deleted the bpo-42299 branch

November 25, 2020 13:17

terryjreedy commented Nov 25, 2020

Copy link

Copy Markdown

Member

Victor, I was inspired to add a 'solution' by your sentence from issue 39352: "I'm no longer sure that it's a good idea to remove a module from the stdlib without providing a solution for the few people relying on it." In this case, I am convinced that copying is a better solution than putting the module on PyPI.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

adorilson pushed a commit to adorilson/cpython that referenced this pull request

Mar 13, 2021


          bpo-42299: Remove formatter module (pythonGH-23476)

0e35556

Reviewers

terryjreedy

terryjreedy requested changes

vstinner

vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

corona10 commented Nov 23, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

corona10 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

terryjreedy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

terryjreedy left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Nov 24, 2020

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

corona10 commented Nov 25, 2020

Uh oh!

terryjreedy commented Nov 25, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

corona10 commented Nov 23, 2020 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.