GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42487: don't call __getitem__ of underlying maps in ChainMap.__iter__ by ap-- · Pull Request #23534 · python/cpython

Conversation

@ap--

@ap-- ap-- commented Nov 28, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

See: https://bugs.python.org/issue42487

https://bugs.python.org/issue42487

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ap--
Do not call __getitem__ on underlying maps in ChainMap.__iter__
9aa564d
@ap--
ap-- requested a review from rhettinger as a code owner November 28, 2020 01:00
@the-knights-who-say-ni

the-knights-who-say-ni commented Nov 28, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@ap--

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Nov 28, 2020
@bedevere-bot bedevere-bot added the awaiting review label Nov 28, 2020
@rhettinger rhettinger self-assigned this Nov 28, 2020
@bedevere-bot bedevere-bot removed the awaiting review label Nov 28, 2020
@bedevere-bot

bedevere-bot commented Nov 28, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Nov 28, 2020
rhettinger
rhettinger requested changes Nov 28, 2020
View reviewed changes

@rhettinger rhettinger left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests and a blurb entry for Misc/NEWS. Also, please get the CLA signed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rhettinger
rhettinger requested a review from serhiy-storchaka November 28, 2020 01:53
ap-- added 2 commits November 28, 2020 04:24
@ap--
Add test for ChainMap.__iter__
48aa670
@ap--
Add blurb
e732767
@ap--

ap-- commented Nov 28, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Hi @rhettinger,
I added a test and the news blurb and signed the CLA (though it states on bpo it may take up to a few days to register...)

Thanks for the quick review and feedback :)

Cheers,
Andreas
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes Nov 28, 2020
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting changes labels Nov 28, 2020
@rhettinger rhettinger added the needs backport to 3.9 label Nov 28, 2020
rhettinger
rhettinger approved these changes Nov 28, 2020
View reviewed changes
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Nov 30, 2020
@rhettinger
rhettinger merged commit 0be9ce3 into python:master Nov 30, 2020
@miss-islington

miss-islington commented Nov 30, 2020

Copy link
Copy Markdown
Contributor

Thanks @ap-- for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 30, 2020
@bedevere-bot

bedevere-bot commented Nov 30, 2020

Copy link
Copy Markdown

GH-23569 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Nov 30, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 30, 2020
@ap-- @miss-islington
bpo-42487: don't call __getitem__ of underlying maps in ChainMap.__it…
3df7f26 
…er__ (pythonGH-23534)

(cherry picked from commit 0be9ce3)

Co-authored-by: Andreas Poehlmann <[email protected]>
rhettinger pushed a commit that referenced this pull request Nov 30, 2020
@miss-islington
bpo-42487: don't call __getitem__ of underlying maps in ChainMap.__it…
cf22aa3 
…er__ (GH-23534) (GH-23569)
@ap--
ap-- deleted the chainmap-iter branch November 30, 2020 17:18
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@ap-- @adorilson
bpo-42487: don't call __getitem__ of underlying maps in ChainMap.__it…
b18ade5 
…er__ (pythonGH-23534)
@Alexamk Alexamk mentioned this pull request Jun 2, 2022
Iterating over ChainMap.values() and ChainMap.items() updates underlying defaultdicts #93432
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger rhettinger approved these changes
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rhettinger rhettinger

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@ap-- @the-knights-who-say-ni @bedevere-bot @miss-islington @rhettinger @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.