GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42262: Py_NewRef() casts its argument to PyObject* by vstinner · Pull Request #23626 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Dec 3, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Write also unit tests on Py_NewRef() and Py_XNewRef().

https://bugs.python.org/issue42262

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-42262: Py_NewRef() casts its argument to PyObject*
728fc89 
Write also unit tests on Py_NewRef() and Py_XNewRef().
@vstinner vstinner added the skip news label Dec 3, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 3, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Dec 3, 2020
@vstinner

vstinner commented Dec 3, 2020

Copy link
Copy Markdown
Member Author

test_asyncio failed on Windows x64. I re-run the job.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Dec 3, 2020

Copy link
Copy Markdown
Member Author

test_asyncio failed again: https://bugs.python.org/issue42553

FAIL: test_call_later (test.test_asyncio.test_events.SelectEventLoopTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\lib\test\test_asyncio\test_events.py", line 301, in test_call_later
    self.assertTrue(0.08 <= t1-t0 <= 0.8, t1-t0)
AssertionError: False is not true : 0.07799999999997453
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 8b6c4a9 into python:master Dec 3, 2020
@bedevere-bot bedevere-bot removed the awaiting core review label Dec 3, 2020
@vstinner
vstinner deleted the newref_cast branch December 3, 2020 13:01
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@vstinner @adorilson
bpo-42262: Py_NewRef() casts its argument to PyObject* (pythonGH-23626)
2bf2fd3 
Write also unit tests on Py_NewRef() and Py_XNewRef().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.