GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-5054: CGIHTTPRequestHandler.run_cgi() HTTP_ACCEPT improperly parsed by orsenthil · Pull Request #23638 · python/cpython

Conversation

@orsenthil

@orsenthil orsenthil commented Dec 4, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member 
[bpo-5054](https://bugs.python.org/issue5054): CGIHTTPRequestHandler.run_cgi() HTTP_ACCEPT improperly parsed

Replace the special purpose getallmatchingheaders with generic get_all method and add relevant tests.

Original Patch by Martin Panter. Modified by Senthil Kumaran.

https://bugs.python.org/issue5054

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
orsenthil added 3 commits December 2, 2020 20:55
@orsenthil
CGI Accept Header Patch.
897156a
@orsenthil
Update HTTP Servers.
78dd084
@orsenthil
Update News
6cd1037
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 4, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Dec 4, 2020
@orsenthil
orsenthil merged commit da3d2ab into python:master Dec 5, 2020
@bedevere-bot

bedevere-bot commented Dec 5, 2020

Copy link
Copy Markdown

@orsenthil: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Dec 5, 2020
@orsenthil orsenthil added the needs backport to 3.9 label Dec 5, 2020
@miss-islington

miss-islington commented Dec 5, 2020

Copy link
Copy Markdown
Contributor

Thanks @orsenthil for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Dec 5, 2020

Copy link
Copy Markdown

GH-23657 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Dec 5, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2020
@orsenthil @miss-islington
pythonGH-5054: CGIHTTPRequestHandler.run_cgi() HTTP_ACCEPT improperly…
ea3d074 
… parsed (pythonGH-23638)

(cherry picked from commit da3d2ab)

Co-authored-by: Senthil Kumaran <[email protected]>
miss-islington added a commit that referenced this pull request Dec 5, 2020
@miss-islington
[3.9] bpo-5054: CGIHTTPRequestHandler.run_cgi() HTTP_ACCEPT improperl…
b630ca7 
…y parsed (GH-23638) (GH-23657)

(cherry picked from commit da3d2ab)


Co-authored-by: Senthil Kumaran <[email protected]>

Automerge-Triggered-By: GH:orsenthil
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@orsenthil @adorilson
pythonGH-5054: CGIHTTPRequestHandler.run_cgi() HTTP_ACCEPT improperly…
fedf9af 
… parsed (python#23638)
@ambv ambv mentioned this pull request Jul 15, 2021
bpo-44647: Fix test_httpservers failing on Unicode characters in os.environ on Windows #27161
Merged
ambv added a commit that referenced this pull request Jul 15, 2021
@ambv
bpo-44647: Fix test_httpservers failing on Unicode characters in os.e…
82b218f 
…nviron on Windows (GH-27161)

GH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test.
This was referenced Jul 15, 2021
[3.10] bpo-44647: Fix test_httpservers failing on Unicode characters in os.environ on Windows (GH-27161) #27169
Merged
[3.9] bpo-44647: Fix test_httpservers failing on Unicode characters in os.environ on Windows (GH-27161) #27170
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 15, 2021
@ambv @miss-islington
bpo-44647: Fix test_httpservers failing on Unicode characters in os.e…
002d862 
…nviron on Windows (pythonGH-27161)

pythonGH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test.
(cherry picked from commit 82b218f)

Co-authored-by: Łukasz Langa <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 15, 2021
@ambv @miss-islington
bpo-44647: Fix test_httpservers failing on Unicode characters in os.e…
4500268 
…nviron on Windows (pythonGH-27161)

pythonGH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test.
(cherry picked from commit 82b218f)

Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Jul 15, 2021
@miss-islington @ambv
bpo-44647: Fix test_httpservers failing on Unicode characters in os.e…
356bdff 
…nviron on Windows (GH-27161) (#27169)

GH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test.
(cherry picked from commit 82b218f)

Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Jul 15, 2021
@miss-islington @ambv
bpo-44647: Fix test_httpservers failing on Unicode characters in os.e…
95596d5 
…nviron on Windows (GH-27161) (#27170)

GH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test.
(cherry picked from commit 82b218f)

Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@orsenthil @bedevere-bot @miss-islington @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.