GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-30459: Cast the result of PyCell_SET to void by vstinner · Pull Request #23654 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Dec 5, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue30459

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 5, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Dec 5, 2020
@vstinner vstinner mentioned this pull request Dec 5, 2020
bpo-30459: Cast the result of PyList_SET_ITEM() to void #19975
Merged
serhiy-storchaka
serhiy-storchaka reviewed Dec 5, 2020
View reviewed changes
Comment thread Doc/whatsnew/3.10.rst Outdated

@serhiy-storchaka serhiy-storchaka Dec 5, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that PyList_SET_ITEM etc are no longer rvalues and have type void. Or something like.

Casting to void is an implementation detail. What is important to the user that they can no longer write x = PyList_SET_ITEM(a, b, c) or PyList_SET_ITEM(a, b, c) = x.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-30459: Cast the result of PyCell_SET to void
6e13416
@vstinner

vstinner commented Dec 7, 2020

Copy link
Copy Markdown
Member Author

@serhiy-storchaka: I rewrote the NEWS entry/What's New entry. Is it better?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes Dec 7, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Dec 7, 2020
@vstinner
vstinner merged commit 0ef96c2 into python:master Dec 7, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 7, 2020
@vstinner

vstinner commented Dec 7, 2020

Copy link
Copy Markdown
Member Author

Thanks for the review @serhiy-storchaka!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the pycell_set branch December 7, 2020 10:56
@serhiy-storchaka

serhiy-storchaka commented Dec 7, 2020

Copy link
Copy Markdown
Member

Thank you for catching the case of PyCell_SET. I missed it.

And this change was worth to be documented.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Dec 7, 2020

Copy link
Copy Markdown
Member Author

And this change was worth to be documented.

My experience with rebuilding Fedora with a newer Python version is that every single minor change breaks at least one Python package, and it's a pain to find which change broke the package, and then find information about the change. IMO it's a good practice to document changes which are backward incompatible on purpose, even if the new behavior was the documented behavior.
serhiy-storchaka reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@vstinner @adorilson
bpo-30459: Cast the result of PyCell_SET to void (pythonGH-23654)
278699c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.