GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix reStructuredText syntax in NEWS.d. by JulienPalard · Pull Request #23800 · python/cpython

Conversation

@JulienPalard

@JulienPalard JulienPalard commented Dec 16, 2020

Copy link
Copy Markdown
Member

Without this "separator", the reStructuredText parser gets it wrong.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JulienPalard
Fix reStructuredText typo in NEWS.d.
6c72f80
@JulienPalard JulienPalard added skip issue skip news labels Dec 16, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 16, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Dec 16, 2020
@JulienPalard JulienPalard mentioned this pull request Dec 16, 2020
bpo-42238: Check Misc/NEWS.d/next/ for reStructuredText issues. #23802
Merged
Fidget-Spinner
Fidget-Spinner approved these changes Dec 16, 2020
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry I wrote this news item. Thanks for fixing this! I couldn't understand why the GitHub rst highlighting was showing up like that, but now I do. Forgot that inline markup needs escaped whitespace :). Guess I need more rst practice.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JulienPalard

JulienPalard commented Dec 16, 2020

Copy link
Copy Markdown
Member Author

@Fidget-Spinner no worries :) A slow CI check was finding those errors, but with false positives. I'm in the process of removing/replacing it, see #23802
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JulienPalard
JulienPalard merged commit 37caeb1 into python:master Dec 16, 2020
@bedevere-bot bedevere-bot removed the awaiting core review label Dec 16, 2020
@JulienPalard
JulienPalard deleted the fix-new branch December 16, 2020 15:22
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@JulienPalard @adorilson
Fix reStructuredText typo in NEWS.d. (pythonGH-23800)
d169dcb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JulienPalard @Fidget-Spinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.