GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-38323: Add guard clauses in MultiLoopChildWatcher. (GH-22756) by miss-islington · Pull Request #23807 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Dec 16, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This is a trivial refactor in preparation for a fix for bpo-38323.
(cherry picked from commit 66d3b58)

Co-authored-by: Chris Jerdonek [email protected]

https://bugs.python.org/issue38323

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cjerdonek @miss-islington
bpo-38323: Add guard clauses in MultiLoopChildWatcher. (pythonGH-22756)
db46071 
This is a trivial refactor in preparation for a fix for bpo-38323.
(cherry picked from commit 66d3b58)

Co-authored-by: Chris Jerdonek <[email protected]>
@miss-islington
miss-islington requested review from 1st1 and asvetlov as code owners December 16, 2020 17:50
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 16, 2020
@bedevere-bot bedevere-bot mentioned this pull request Dec 16, 2020
bpo-38323: Add guard clauses in MultiLoopChildWatcher. #22756
Merged
@bedevere-bot bedevere-bot added the skip news label Dec 16, 2020
@miss-islington

miss-islington commented Dec 16, 2020

Copy link
Copy Markdown
Contributor Author

@cjerdonek and @asvetlov: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Dec 16, 2020
asvetlov
asvetlov approved these changes Dec 16, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Dec 16, 2020
@miss-islington

miss-islington commented Dec 16, 2020

Copy link
Copy Markdown
Contributor Author

@cjerdonek and @asvetlov: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit dd262ef into python:3.8 Dec 16, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 16, 2020
@miss-islington
miss-islington deleted the backport-66d3b58-3.8 branch December 16, 2020 18:11
@vstinner vstinner mentioned this pull request Apr 10, 2022
asyncio: MultiLoopWatcher has a race condition (test_asyncio: test_close_kill_running() hangs on AMD64 RHEL7 Refleaks 3.x) #82504
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @asvetlov @the-knights-who-say-ni @bedevere-bot @cjerdonek
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.