GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-38323: Add guard clauses in MultiLoopChildWatcher. by cjerdonek · Pull Request #22756 · python/cpython

Conversation

@cjerdonek

@cjerdonek cjerdonek commented Oct 18, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is a trivial refactor in preparation for a fix for bpo-38323 (see #20142).

https://bugs.python.org/issue38323

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cjerdonek
bpo-38323: Add guard clauses in MultiLoopChildWatcher.
f855209 
This is a trivial refactor in preparation for a fix for bpo-38323.
@cjerdonek
cjerdonek requested review from 1st1 and asvetlov as code owners October 18, 2020 21:58
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 18, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Oct 18, 2020
@cjerdonek cjerdonek added the skip news label Oct 18, 2020
@cjerdonek cjerdonek mentioned this pull request Oct 18, 2020
[WIP] bpo-38323: Fix MultiLoopChildWatcher hangs #20142
Closed
@cjerdonek cjerdonek closed this Oct 19, 2020
@cjerdonek cjerdonek reopened this Oct 19, 2020
aeros
aeros approved these changes Nov 7, 2020
View reviewed changes

@aeros aeros left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the delay, I got caught up with organizing the sprint (and participating the week of Oct. 19-23), then took a bit of a break after it was over.

With usage of guard clauses instead of an additional layer of nested indents though, I found it significantly easier to mentally parse (which makes a difference especially for someone less experienced w/ non-trivial signal handling, like myself). Also, thanks for splitting this refactor away from #20142, that definitely makes the review process easier.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 7, 2020
@github-actions

github-actions Bot commented Dec 16, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
asvetlov
asvetlov approved these changes Dec 16, 2020
View reviewed changes
@asvetlov asvetlov added needs backport to 3.8 labels Dec 16, 2020
@asvetlov
asvetlov merged commit 66d3b58 into python:master Dec 16, 2020
@miss-islington

miss-islington commented Dec 16, 2020

Copy link
Copy Markdown
Contributor

Thanks @cjerdonek for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Dec 16, 2020

Copy link
Copy Markdown

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 16, 2020
@asvetlov

asvetlov commented Dec 16, 2020

Copy link
Copy Markdown
Contributor

Thanks! Sorry for delay
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Dec 16, 2020
@bedevere-bot

bedevere-bot commented Dec 16, 2020

Copy link
Copy Markdown

GH-23806 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2020
@cjerdonek @miss-islington
bpo-38323: Add guard clauses in MultiLoopChildWatcher. (pythonGH-22756)
8b27218 
This is a trivial refactor in preparation for a fix for bpo-38323.
(cherry picked from commit 66d3b58)

Co-authored-by: Chris Jerdonek <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2020
@cjerdonek @miss-islington
bpo-38323: Add guard clauses in MultiLoopChildWatcher. (pythonGH-22756)
db46071 
This is a trivial refactor in preparation for a fix for bpo-38323.
(cherry picked from commit 66d3b58)

Co-authored-by: Chris Jerdonek <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Dec 16, 2020
@bedevere-bot

bedevere-bot commented Dec 16, 2020

Copy link
Copy Markdown

GH-23807 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Dec 16, 2020
@miss-islington @cjerdonek
bpo-38323: Add guard clauses in MultiLoopChildWatcher. (GH-22756)
bf0eed3 
This is a trivial refactor in preparation for a fix for bpo-38323.
(cherry picked from commit 66d3b58)

Co-authored-by: Chris Jerdonek <[email protected]>
miss-islington added a commit that referenced this pull request Dec 16, 2020
@miss-islington @cjerdonek
bpo-38323: Add guard clauses in MultiLoopChildWatcher. (GH-22756)
dd262ef 
This is a trivial refactor in preparation for a fix for bpo-38323.
(cherry picked from commit 66d3b58)

Co-authored-by: Chris Jerdonek <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@cjerdonek @adorilson
bpo-38323: Add guard clauses in MultiLoopChildWatcher. (python#22756)
b9a14d4 
This is a trivial refactor in preparation for a fix for bpo-38323.
@vstinner vstinner mentioned this pull request Apr 10, 2022
asyncio: MultiLoopWatcher has a race condition (test_asyncio: test_close_kill_running() hangs on AMD64 RHEL7 Refleaks 3.x) #82504
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes
@1st1 1st1 Awaiting requested review from 1st1
+1 more reviewer
@aeros aeros aeros approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@cjerdonek @miss-islington @bedevere-bot @asvetlov @aeros @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.