GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42755: Fix sqlite3.Connection.backup docs by erlend-aasland · Pull Request #23965 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Dec 27, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The pages argument default value now reflects the implementation.

https://bugs.python.org/issue42755

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-42755: Fix sqlite3.Connection.backup docs
b62b8da 
The `pages` argument default value now reflects the implementation.
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner December 27, 2020 10:18
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 27, 2020
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 27, 2020
@erlend-aasland

erlend-aasland commented Dec 27, 2020

Copy link
Copy Markdown
Contributor Author

FYI, @corona10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Dec 27, 2020

Copy link
Copy Markdown
Contributor Author

3.9 and 3.8 have the same discrepancies, @pablogsal, so I guess backport labels are needed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Dec 27, 2020

Copy link
Copy Markdown
Contributor Author

Skip news?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 added needs backport to 3.8 skip news labels Dec 27, 2020
pablogsal
pablogsal approved these changes Dec 27, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Dec 27, 2020
@pablogsal
pablogsal merged commit abba83b into python:master Dec 27, 2020
@miss-islington

miss-islington commented Dec 27, 2020

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 27, 2020
@pablogsal

pablogsal commented Dec 27, 2020

Copy link
Copy Markdown
Member

Thanks for the PR @erlend-aasland !
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Dec 27, 2020

Copy link
Copy Markdown

GH-23970 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Dec 27, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 27, 2020
Erlend Egeberg Aasland @miss-islington
bpo-42755: Fix sqlite3.Connection.backup docs (pythonGH-23965)
06b1939 
The `pages` argument default value now reflects the implementation.
(cherry picked from commit abba83b)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@erlend-aasland
erlend-aasland deleted the sqlite/backup-default-value branch December 27, 2020 22:35
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Dec 27, 2020
@bedevere-bot

bedevere-bot commented Dec 27, 2020

Copy link
Copy Markdown

GH-23971 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 27, 2020
Erlend Egeberg Aasland @miss-islington
bpo-42755: Fix sqlite3.Connection.backup docs (pythonGH-23965)
b44c2e6 
The `pages` argument default value now reflects the implementation.
(cherry picked from commit abba83b)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington added a commit that referenced this pull request Dec 27, 2020
@miss-islington Erlend Egeberg Aasland
bpo-42755: Fix sqlite3.Connection.backup docs (GH-23965)
9f6a37c 
The `pages` argument default value now reflects the implementation.
(cherry picked from commit abba83b)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
berkerpeksag pushed a commit that referenced this pull request Jan 6, 2021
@miss-islington Erlend Egeberg Aasland
bpo-42755: Fix sqlite3.Connection.backup docs (GH-23965)
28611c2 
The `pages` argument default value now reflects the implementation.
(cherry picked from commit abba83b)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland @adorilson
bpo-42755: Fix sqlite3.Connection.backup docs (pythonGH-23965)
469417a 
The `pages` argument default value now reflects the implementation.
@erlend-aasland erlend-aasland mentioned this pull request Jul 27, 2022
Improve the sqlite3 reference #95273
Closed
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@erlend-aasland @miss-islington @pablogsal @bedevere-bot @corona10 @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.