GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-27794: Add `name` attribute to `property` class by uriyyo · Pull Request #23967 · python/cpython

Conversation

uriyyo commented Dec 27, 2020 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

https://bugs.python.org/issue27794

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Add name attribute to property class

de0962b

the-knights-who-say-ni added the CLA signed label

Dec 27, 2020

bedevere-bot added the awaiting review label

Dec 27, 2020


          Fix property test cases

a041466

rhettinger self-assigned this

Dec 27, 2020


          Fix issue with incorrect exc message

89b5b21

uriyyo force-pushed the fix-issue-27794 branch from ef7003a to 89b5b21 Compare

December 27, 2020 22:03


          remove name from property init method

f02f68c

rhettinger reviewed

Dec 28, 2020

View reviewed changes

Comment thread

Objects/descrobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

rhettinger reviewed

Dec 28, 2020

View reviewed changes

Comment thread

Misc/NEWS.d/next/Core and Builtins/2020-12-27-18-07-43.bpo-27794.sxgfGi.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

rhettinger requested changes

Dec 28, 2020

View reviewed changes

Comment thread

Doc/howto/descriptor.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/howto/descriptor.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/howto/descriptor.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting review label

Dec 28, 2020

bedevere-bot commented Dec 28, 2020

Copy link

Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added the awaiting changes label

Dec 28, 2020

rhettinger reviewed

Dec 28, 2020

View reviewed changes

Comment thread

Objects/descrobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

rhettinger reviewed

Dec 28, 2020

View reviewed changes

Comment thread

Objects/descrobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

uriyyo added 2 commits

December 28, 2020 10:39


          Make name attribute private

b502907


          fix docs

6aa55bd

uriyyo commented Dec 28, 2020

Copy link

Copy Markdown

Member Author

I have made the requested changes; please review again

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting change review and removed awaiting changes labels

Dec 28, 2020

bedevere-bot commented Dec 28, 2020

Copy link

Copy Markdown

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot requested a review from rhettinger

December 28, 2020 08:57

rhettinger requested changes

Dec 29, 2020

View reviewed changes

Comment thread

Doc/howto/descriptor.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Objects/descrobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Dec 29, 2020

Copy link

Copy Markdown

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting changes and removed awaiting change review labels

Dec 29, 2020


          Remove strip call from docs, remove extra blank line

2c83769

uriyyo commented Dec 29, 2020

Copy link

Copy Markdown

Member Author

I have made the requested changes; please review again

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting changes label

Dec 29, 2020

bedevere-bot added the awaiting change review label

Dec 29, 2020

bedevere-bot commented Dec 29, 2020

Copy link

Copy Markdown

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot requested a review from rhettinger

December 29, 2020 08:36

rhettinger requested changes

Dec 29, 2020

View reviewed changes

Comment thread

Objects/descrobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/howto/descriptor.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/howto/descriptor.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Objects/descrobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Objects/descrobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting change review label

Dec 29, 2020

bedevere-bot commented Dec 29, 2020

Copy link

Copy Markdown

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added the awaiting changes label

Dec 29, 2020


          Update docs and property __set_name__ method

d2b4e63

uriyyo commented Dec 29, 2020

Copy link

Copy Markdown

Member Author

I have made the requested changes; please review again

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting change review and removed awaiting changes labels

Dec 29, 2020

bedevere-bot commented Dec 29, 2020

Copy link

Copy Markdown

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot requested a review from rhettinger

December 29, 2020 20:30

rhettinger merged commit c56387f into python:master

Dec 30, 2020

bedevere-bot removed the awaiting change review label

Dec 30, 2020

adorilson pushed a commit to adorilson/cpython that referenced this pull request

Mar 13, 2021


          bpo-27794: Add name attribute to property class (pythonGH-23967)

9379dc7

Reviewers

rhettinger

Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

rhettinger

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

uriyyo commented Dec 27, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Dec 28, 2020

Uh oh!

Uh oh!

Uh oh!

uriyyo commented Dec 28, 2020

Uh oh!

bedevere-bot commented Dec 28, 2020

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Dec 29, 2020

Uh oh!

uriyyo commented Dec 29, 2020

Uh oh!

bedevere-bot commented Dec 29, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Dec 29, 2020

Uh oh!

uriyyo commented Dec 29, 2020

Uh oh!

bedevere-bot commented Dec 29, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

uriyyo commented Dec 27, 2020 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.