GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42048: Document AC's defining_class converter by erlend-aasland · Pull Request #23978 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Dec 28, 2020 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Parts of this documentation is more or less taken/stolen directly from PEP 573

https://bugs.python.org/issue42048

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-42048: Document AC's defining_class converter
c508365
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 28, 2020
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 28, 2020
@erlend-aasland

erlend-aasland commented Dec 28, 2020

Copy link
Copy Markdown
Contributor Author

cc @vstinner, as promised at #22478 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland
Fix inline literals
dedc115
vstinner
vstinner reviewed Jan 20, 2021
View reviewed changes
Comment thread Doc/howto/clinic.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/howto/clinic.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/howto/clinic.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/howto/clinic.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend Egeberg Aasland and others added 2 commits January 20, 2021 10:28
Erlend Egeberg Aasland @vstinner
Use PEP marker
38df615 
Co-authored-by: Victor Stinner <[email protected]>
Erlend E. Aasland
Address review
acf0f7e
@erlend-aasland

erlend-aasland commented Jan 20, 2021

Copy link
Copy Markdown
Contributor Author

PTAL, @vstinner. I've expanded the zlib example, added some lines about heap types and PyType_FromModuleAndSpec, and added some lines about slot methods and _PyType_GetModuleByDef (together with a small example from the thread module). I also removed info about the calling convention.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Jan 20, 2021
View reviewed changes
Comment thread Doc/howto/clinic.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/howto/clinic.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend Egeberg Aasland and others added 3 commits January 20, 2021 11:27
Erlend Egeberg Aasland @vstinner
Close the braces
08a7132 
Co-authored-by: Victor Stinner <[email protected]>
Erlend E. Aasland
Address review: Move note about _PyType_GetModuleByDef being slow
580d004
Erlend E. Aasland
Fix .rst bug
19b306f
vstinner
vstinner reviewed Jan 20, 2021
View reviewed changes
Comment thread Doc/howto/clinic.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend Egeberg Aasland and others added 2 commits January 20, 2021 12:01
Erlend Egeberg Aasland @vstinner
Fix typo: follwing => following
97ec8e8 
Co-authored-by: Victor Stinner <[email protected]>
Erlend E. Aasland
Fix .rst bug: default role used
50a9143
vstinner
vstinner approved these changes Jan 20, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jan 20, 2021
@vstinner vstinner added the 🤖 automerge label Jan 20, 2021
@miss-islington

miss-islington commented Jan 20, 2021

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Jan 20, 2021

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jan 20, 2021

Copy link
Copy Markdown
Contributor Author

@vstinner I guess the bot need a skip news flag? Or should I add a news item?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added skip news and removed 🤖 automerge labels Jan 20, 2021
@vstinner
vstinner merged commit e982fe4 into python:master Jan 20, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 20, 2021
@erlend-aasland
erlend-aasland deleted the ac-document-defining-class branch January 20, 2021 11:20
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland @adorilson
bpo-42048: Clinic Howto: Document AC's defining_class converter (pyth…
b662ac1 
…onGH-23978)
erlend-aasland pushed a commit to erlend-aasland/devguide that referenced this pull request Sep 8, 2023
Erlend Egeberg Aasland @erlend-aasland
bpo-42048: Clinic Howto: Document AC's defining_class converter (pyth…
902a8f8 
…on/cpython#23978)
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Sep 13, 2023
Erlend Egeberg Aasland
bpo-42048: Clinic Howto: Document AC's defining_class converter (pyth…
403488f 
…on/cpython#23978)

GitHub-Issue-Link: python/cpython#86214
erlend-aasland pushed a commit to python/devguide that referenced this pull request Sep 26, 2023
Erlend Egeberg Aasland @erlend-aasland
bpo-42048: Clinic Howto: Document AC's defining_class converter (pyth…
f314e51 
…on/cpython#23978)

GitHub-Issue-Link: python/cpython#86214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.