GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41559: Documentation for PEP 612 by Fidget-Spinner · Pull Request #24000 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Dec 29, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Please skip news, it shares the same news entry as GH-23702, thanks!

https://bugs.python.org/issue41559

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fidget-Spinner
docs for pep612
18d63f2
@Fidget-Spinner
Fidget-Spinner requested review from gvanrossum and ilevkivskyi as code owners December 29, 2020 17:34
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 29, 2020
@bedevere-bot bedevere-bot added the awaiting review label Dec 29, 2020
@Fidget-Spinner

Fidget-Spinner commented Dec 29, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@gvanrossum. Sorry, I did the reverse of what I'd initially promised - I was in a writing mood :). Really no hurry to review it though, we have a long way till 3.10 beta.

This felt more difficult to write than what I did for PEP 585 and PEP 604 combined! Thinking of useful examples which were also understandable by users and copy-pastable/fully working as is wasn't easy. Maybe this is a sign that the typing module needs some refactoring work by the future Docs WG people.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner added 3 commits December 30, 2020 17:16
@Fidget-Spinner
polish up docs
a2fc0d1
@Fidget-Spinner
remove repetitive statements
bebe250
@Fidget-Spinner
polish flow
2e13c99
@Fidget-Spinner

Fidget-Spinner commented Dec 30, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Hmm I wonder if we should reorder the PEP-sized what's new items while we're at it. Strange that the current order is PEP 563, 613, 604, 612.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
Merge remote-tracking branch 'upstream/master' into docs-pep612
ece68b8
gvanrossum
gvanrossum reviewed Dec 30, 2020
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this very thorough doc update! I have just a few nits.

Next, do you want to help fixing the support for this in mypy? There's some code, but it's not working right.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/stdtypes.rst
.. note::
A ``GenericAlias`` object with :class:`typing.ParamSpec` parameters may not
have correct ``__parameters__`` after substitution because
:class:`typing.ParamSpec` is intended primarily for static type checking.

@gvanrossum gvanrossum Dec 30, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to add this to the note, but privately I'm interested in an example where it goes wrong?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Fidget-Spinner Fidget-Spinner Dec 31, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

'''This example is from the typing module, though it will behave the same with the builtin GenericAlias'''
from typing import ParamSpec, TypeVar, Generic

P = ParamSpec('P')
T = TypeVar('T')

class X(Generic[P]): ...

# Empty tuple, because T is nested inside that list
print(X[int, str, T].__parameters__)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner @gvanrossum
use suggestions
21f9958 
Co-Authored-By: Guido van Rossum <[email protected]>
@Fidget-Spinner

Fidget-Spinner commented Dec 31, 2020

Copy link
Copy Markdown
Member Author

Thanks so much for this very thorough doc update! I have just a few nits.

Next, do you want to help fixing the support for this in mypy? There's some code, but it's not working right.

You're welcome! Unfortunately I have no clue how mypy works internally, so I don't think I'm the right person for that right now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum
gvanrossum reviewed Dec 31, 2020
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else is fine now!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner added 2 commits December 31, 2020 13:19
@Fidget-Spinner
fix up problems
2ea0761
@Fidget-Spinner
small nit
4eb116b
gvanrossum
gvanrossum approved these changes Dec 31, 2020
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Dec 31, 2020
@gvanrossum gvanrossum added the skip news label Dec 31, 2020
@Fidget-Spinner

Fidget-Spinner commented Jan 1, 2021

Copy link
Copy Markdown
Member Author

Thank you for taking the time to review this prosaic chunk of text. Getting this approved is an awesome way to start the new year!

BTW, test_nntplib seems to be failing for the entire cpython repo right now. I'm just going to wait it out and see if it magically fixes itself, or if the people at https://bugs.python.org/issue42794 find some other way to solve it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
Merge remote-tracking branch 'upstream/master' into docs-pep612
f314a34
@gvanrossum
gvanrossum merged commit 11276cd into python:master Jan 2, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 2, 2021
@Fidget-Spinner
Fidget-Spinner deleted the docs-pep612 branch January 2, 2021 09:09
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@Fidget-Spinner @adorilson
bpo-41559: Documentation for PEP 612 (pythonGH-24000)
24c3210
@johnslavik johnslavik mentioned this pull request Dec 20, 2025
Clarify the valid use locations of typing.Concatenate python/typing#2140
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Fidget-Spinner @gvanrossum @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.