GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Bring Python into the new year. by corona10 · Pull Request #24036 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Jan 1, 2021

Copy link
Copy Markdown
Member

Happy New Year ;)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rrhodes and olfMombach reacted with hooray emoji
All reactions
  • 🎉 2 reactions
@corona10
corona10 requested review from benjaminp, pablogsal and vstinner January 1, 2021 06:56
@corona10
corona10 requested a review from a team as a code owner January 1, 2021 06:56
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 1, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Jan 1, 2021
@corona10 corona10 added skip issue skip news needs backport to 3.7 labels Jan 1, 2021
@ghost

ghost commented Jan 1, 2021

Copy link
Copy Markdown

There is a "2016" in cpython/PC/python_ver_rc.h, it could be changed to 2021.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
corona10 requested a review from a team as a code owner January 1, 2021 13:36
corona10 added 2 commits January 1, 2021 23:23
@corona10
Bring Python into the new year.
f7ebb01
@corona10
Update
e6cfd9b
@corona10
corona10 force-pushed the happy_new_year branch from f285dc2 to e6cfd9b Compare January 1, 2021 14:24
@vstinner

vstinner commented Jan 1, 2021

Copy link
Copy Markdown
Member

Last year, @benjaminp did the commit: commit 946b29e.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Jan 1, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

You modified the same files than last year commit, but you also updated PC/python_ver_rc.h which is a good thing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 1, 2021
@corona10
corona10 merged commit de6f20a into python:master Jan 1, 2021
@miss-islington

miss-islington commented Jan 1, 2021

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7, 3.8, 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 1, 2021
@bedevere-bot

bedevere-bot commented Jan 1, 2021

Copy link
Copy Markdown

GH-24045 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Jan 1, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 1, 2021
@corona10 @miss-islington
Bring Python into the new year. (pythonGH-24036)
5eb80e5 
(cherry picked from commit de6f20a)

Co-authored-by: Dong-hee Na <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 1, 2021
@corona10 @miss-islington
Bring Python into the new year. (pythonGH-24036)
492cc15 
(cherry picked from commit de6f20a)

Co-authored-by: Dong-hee Na <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Jan 1, 2021
@bedevere-bot

bedevere-bot commented Jan 1, 2021

Copy link
Copy Markdown

GH-24046 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Jan 1, 2021
@bedevere-bot

bedevere-bot commented Jan 1, 2021

Copy link
Copy Markdown

GH-24047 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jan 1, 2021

Copy link
Copy Markdown
Contributor

Sorry, @corona10, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker de6f20a6de48d63066b2cf5b317f50629f01d74a 3.6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned corona10 Jan 1, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 1, 2021
@corona10 @miss-islington
Bring Python into the new year. (pythonGH-24036)
3576348 
(cherry picked from commit de6f20a)

Co-authored-by: Dong-hee Na <[email protected]>
@vstinner vstinner removed the needs backport to 3.6 label Jan 1, 2021
@vstinner

vstinner commented Jan 1, 2021

Copy link
Copy Markdown
Member

This change should not be backported to 3.6 and 3.7, it's not a security fix: https://devguide.python.org/#status-of-python-branches
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Jan 1, 2021
@miss-islington @corona10
Bring Python into the new year. (GH-24036)
fa12749 
(cherry picked from commit de6f20a)

Co-authored-by: Dong-hee Na <[email protected]>
miss-islington added a commit that referenced this pull request Jan 1, 2021
@miss-islington @corona10
Bring Python into the new year. (GH-24036)
02639c3 
(cherry picked from commit de6f20a)

Co-authored-by: Dong-hee Na <[email protected]>
@ned-deily

ned-deily commented Jan 1, 2021

Copy link
Copy Markdown
Member

@vstinner The copyrights are an exception. They should be updated on still active branches.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ned-deily ned-deily added needs backport to 3.6 labels Jan 1, 2021
@miss-islington

miss-islington commented Jan 1, 2021

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jan 1, 2021

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jan 1, 2021

Copy link
Copy Markdown

GH-24052 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Jan 1, 2021
@miss-islington

miss-islington commented Jan 1, 2021

Copy link
Copy Markdown
Contributor

Sorry, @corona10, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker de6f20a6de48d63066b2cf5b317f50629f01d74a 3.6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 1, 2021
@corona10 @miss-islington
Bring Python into the new year. (pythonGH-24036)
826120d 
(cherry picked from commit de6f20a)

Co-authored-by: Dong-hee Na <[email protected]>
@ned-deily

ned-deily commented Jan 1, 2021

Copy link
Copy Markdown
Member

@corona10 If you would care to deal with the merge conflict for 3.6, I'll see that the PR gets merged. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jan 1, 2021

Copy link
Copy Markdown
Member

@vstinner The copyrights are an exception. They should be updated on still active branches.

Oh. I didn't know, good to know.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ned-deily pushed a commit that referenced this pull request Jan 1, 2021
@miss-islington @corona10
Bring Python into the new year. (GH-24036) (GH-24052)
117830d 
(cherry picked from commit de6f20a)

Co-authored-by: Dong-hee Na <[email protected]>
corona10 added a commit to corona10/cpython that referenced this pull request Jan 2, 2021
@corona10
[3.6] Bring Python into the new year. (pythonGH-24036).
74eb270 
(cherry picked from commit de6f20a)

Co-authored-by: Dong-hee Na <[email protected]>
@bedevere-bot

bedevere-bot commented Jan 2, 2021

Copy link
Copy Markdown

GH-24054 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Jan 2, 2021
ned-deily pushed a commit that referenced this pull request Jan 2, 2021
@corona10
[3.6] Bring Python into the new year. (GH-24036). (GH-24054)
415c4a1 
(cherry picked from commit de6f20a)

Co-authored-by: Dong-hee Na <[email protected]>
@corona10
corona10 deleted the happy_new_year branch January 2, 2021 06:20
@pombredanne

pombredanne commented Feb 2, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Reposting from:
de6f20a#diff-c693279643b8cd5d248172d9c22cb7cf4ed163a3c98c8a3f69c2717edd3eacb7R87

Could we stop making these constant changes to the license texts just for a new year? These really do not matter much. Constant changes (as in at least once per year) in the license texts make the downstream identification more complex and brings zero benefits IMHO.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@corona10 @adorilson
Bring Python into the new year. (pythonGH-24036)
93f72a6
@hugovk hugovk mentioned this pull request Oct 29, 2024
Use static copyright years #126133
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@benjaminp benjaminp Awaiting requested review from benjaminp
@pablogsal pablogsal Awaiting requested review from pablogsal

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@corona10 corona10

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@corona10 @vstinner @miss-islington @bedevere-bot @ned-deily @pombredanne @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.