GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40077: Add traverse/clear/free to arraymodule by erlend-aasland · Pull Request #24066 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jan 2, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue40077

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-40077: Add traverse/clear/free to arraymodule
9410494
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 2, 2021
@bedevere-bot bedevere-bot added the awaiting review label Jan 2, 2021
@erlend-aasland

erlend-aasland commented Jan 2, 2021

Copy link
Copy Markdown
Contributor Author

@encukou, would you mind reviewing this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991 shihai1991 added the skip news label Jan 3, 2021
shihai1991
shihai1991 approved these changes Jan 3, 2021
View reviewed changes

@shihai1991 shihai1991 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just a nitpick: PyObject *m--> PyObject *module or PyObject *mod would be more exact.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Jan 3, 2021
@erlend-aasland

erlend-aasland commented Jan 3, 2021

Copy link
Copy Markdown
Contributor Author

LGTM.

Just a nitpick: PyObject *m--> PyObject *module or PyObject *mod would be more exact.

I agree. I'll fix it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland
Address review: m => module
8062a99
@erlend-aasland
erlend-aasland requested a review from shihai1991 January 3, 2021 09:35
@encukou
encukou merged commit b8eb376 into python:master Jan 3, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Jan 3, 2021
@encukou

encukou commented Jan 3, 2021

Copy link
Copy Markdown
Member

Thank you!
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland deleted the bpo-40077/array-fix branch January 3, 2021 13:45
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland @adorilson
bpo-40077: Add traverse/clear/free to arraymodule (pythonGH-24066)
1a9d7e6
@corona10 corona10 mentioned this pull request Jun 27, 2022
Convert static types to heap types: use PyType_FromSpec() #84258
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shihai1991 shihai1991 Awaiting requested review from shihai1991

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @encukou @shihai1991 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.