GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-63882: Adds tests for xml.dom.minidom by karlcow · Pull Request #24152 · python/cpython

Conversation

@karlcow

@karlcow karlcow commented Jan 7, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This is a work in progress not yet ready for review.

https://bugs.python.org/issue19683

  • Issue: test_minidom has many empty tests #63882

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
karlcow added 8 commits January 7, 2021 21:46
@karlcow
bpo-19683: Changes the docstring for the test file
afefc8a
@karlcow
bpo-19683: Adds tests for toxml method
24fd486
@karlcow
bpo-19683: Changes the _repr_ for Node Element
172eacd 
id in the _repr_ method doesn't seem that useful
when sending back a NodeList
Adds also docstrings to some methods.
@karlcow
bpo-19683: Reorganize import for clarity
0d60669
@karlcow
bpo-19683: Adds encoding test for toxml
c106ce5
@karlcow
bpo-19683: Reformats hasChildNodes test
847c6f2
@karlcow
bpo-19683: Adds test for childNodes
c488947
@karlcow
bpo-19683: Adds firstChild and lastChild tests
dc3f100
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 7, 2021
@bedevere-bot bedevere-bot added the awaiting review label Jan 7, 2021
karlcow added 10 commits January 11, 2021 16:52
@karlcow
bpo-19683: Adds test for insertBefore DocumentFragment
14ad87c
@karlcow
bpo-19683: Adds test for insertBefore for invalid NodeType
a009350
@karlcow
bpo-19683: Adds test for insertBefore for text node
709a640
@karlcow
bpo-19683: Adds test for insertBefore without ref node
b6fe778
@karlcow
bpo-19683: Adds tests for insertBefore
95aafaf 
it also removes the old tests so we get more regular tests
@karlcow
bpo-19683: Adds tests for appendChild
896543e 
Removes the old tests.
Adds new tests in a regular form and testing more cases
Adds docstring
@karlcow
bpo-19683: Removes tests which are empty
4dc05ca 
These tests are useless for now. We will be adding them again later with proper code.
@karlcow
bpo-19683: Adds tests firstChild, lastChild
ff99b90 
Some parts of the function were not tested. This is fixing it.
@karlcow
bpo-19683: Adds tests for replaceChild to xml.dom.test_minidom
e5654e8 
* Convert old tests to have a regular form
* Adds new tests to cover more cases.
@karlcow
bpo-19683: Adds tests for removeChild
0da118b 
* Adds tests for removeChild
* Remove old tests
* Fix the docstring for removeChild and replaceChild
@github-actions

github-actions Bot commented Feb 19, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 19, 2021
karlcow added 3 commits February 19, 2021 14:38
@karlcow
bpo-19683: Adds tests for normalize. Part 1
d0d51f2
@karlcow
bpo-19683: Adds tests for normalize. Part 2
52c26c5
@karlcow
bpo-19683: Adds cloneNode tests. Part 1
c8ef460
@zware zware mentioned this pull request May 10, 2022
test_minidom has many empty tests #63882
Closed
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 2, 2022
@terryjreedy terryjreedy changed the title bpo-19683: Adds tests for xml.dom.minidom gh-63882: Adds tests for xml.dom.minidom Nov 29, 2022
@terryjreedy
terryjreedy requested a review from zware November 29, 2022 01:18
@terryjreedy

terryjreedy commented Nov 29, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The merge conflict is a result of new imports for pyexpat and parsers...ExpatError in main. I could easily fix the conflict, but I really do not like putting multiple imports from one module in separate lines and would undo an revise that change also at the same time.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy

terryjreedy commented Nov 29, 2022

Copy link
Copy Markdown
Member

I consider this unreviewable until split into multiple PRs. See #63882 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@karlcow

karlcow commented Nov 29, 2022

Copy link
Copy Markdown
Contributor Author

I can't work on this anymore. Unfortunately.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@karlcow karlcow closed this Nov 29, 2022
@srinivasreddy srinivasreddy mentioned this pull request Jan 4, 2025
gh-128508: Add some docstrings to xml.dom.minidom #128477
Open
@terryjreedy terryjreedy mentioned this pull request Jan 5, 2025
Add some docstrings to xml.dom.minidom #128508
Open
@terryjreedy

terryjreedy commented Jan 5, 2025

Copy link
Copy Markdown
Member

@karlcow Thank you for this draft. The docstring additions have been moved to a new issue #128508 and PR #128477 for revisions. You are listed on the latter as a co-author.

The empty tests should be commented out until replaced, not removed. A new PR should close the issue.

The revised tests, fixing names and code, should be moved to another new issue. With this is done, the tests for class methods should be put in separate TestCase classes. MinidomTest should only have the module function tests.
karlcow reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware Awaiting requested review from zware

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@karlcow @terryjreedy @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.