GeezerVison

Edit by TJR: The two patch files, by two different people deleted empty tests. Some version was merged to Python maintenance versions 2.7 and 3.3 (then on Mercurial) in Dec 2013: #63882 (comment). At that time, 3.4.0, released in March 2014, was tip. PR 24152 added docstrings to minidom.py, removed the empty tests, and revised existing tests. The author closed it due to lack of time when requested to split it into multiple PRs.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2013-11-21.15:17:39.634>
labels = ['easy', 'type-feature', 'tests']
title = 'test_minidom has many empty tests'
updated_at = <Date 2021-01-07.13:48:32.590>
user = 'https://github.com/zware'

bugs.python.org fields:

activity = <Date 2021-01-07.13:48:32.590>
actor = 'karlcow'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2013-11-21.15:17:39.634>
creator = 'zach.ware'
dependencies = []
files = ['32901', '33258']
hgrepos = []
issue_num = 19683
keywords = ['patch', 'easy']
message_count = 21.0
messages = ['203637', '203642', '203643', '204781', '204806', '204834', '205274', '206637', '206639', '206641', '206642', '206873', '206939', '206979', '209897', '209899', '353793', '353835', '384561', '384575', '384576']
nosy_count = 7.0
nosy_names = ['r.david.murray', 'karlcow', 'python-dev', 'zach.ware', 'serhiy.storchaka', 'Julian.Gindi', 'ajitesh.gupta']
pr_nums = ['24152']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19683'
versions = ['Python 3.4']

Linked PRs

Activity

zware commented on Nov 21, 2013
zware
on Nov 21, 2013
MemberAuthor
More actions
Many of the tests in test_minidom on 2.7 are empty, that is they are defined as "def testSomeFunction(self): pass".

I've marked this issue as "easy" since I suspect a lot of the tests can be either backported from 3.x, or removed if they don't exist in 3.x.
zware
added
testsTests in the Lib/test dirTests in the Lib/test dir

easy

type-featureA feature request or enhancementA feature request or enhancement
on Nov 21, 2013
bitdancer commented on Nov 21, 2013
bitdancer
on Nov 21, 2013
Member
More actions
Well, we generally don't backport tests unless we are fixing related bugs. I think this should be left alone.
zware commented on Nov 21, 2013
zware
on Nov 21, 2013
MemberAuthor
More actions
In that case, the empty tests should be removed, since they currently report success on doing nothing.
ajiteshgupta commented on Nov 30, 2013
ajiteshguptamannequin
on Nov 30, 2013
Mannequin
More actions
I have attached a patch. I deleted all the empty tests.
serhiy-storchaka commented on Nov 30, 2013
serhiy-storchaka
on Nov 30, 2013
Member
More actions
Rather than removing these empty tests it will be better implement them. Otherwise we can accidentally break the code.

I see a lot of empty tests on 3.x.
bitdancer commented on Nov 30, 2013
bitdancer
on Nov 30, 2013
Member
More actions
On tip it would indeed be better to implement them. The deletion is only for the released branches.
JulianGindi commented on Dec 5, 2013
JulianGindimannequin
on Dec 5, 2013
Mannequin
More actions
I agree that they should be implemented. I'll fill them in and submit a patch in a day or so.
python-dev commented on Dec 19, 2013
python-devmannequin
on Dec 19, 2013
Mannequin
More actions
New changeset 2737c0e7ba71 by Zachary Ware in branch '2.7':
Issue bpo-19683: Removed empty tests from test_minidom.
http://hg.python.org/cpython/rev/2737c0e7ba71

New changeset 5e510117b71a by Zachary Ware in branch '3.3':
Issue bpo-19683: Removed empty tests from test_minidom. Patch by Ajitesh Gupta.
http://hg.python.org/cpython/rev/5e510117b71a
zware commented on Dec 19, 2013
zware
on Dec 19, 2013
MemberAuthor
More actions
Thanks for the removal patch, Ajitesh!

Julian, are you still working on implementing the tests on default?
JulianGindi commented on Dec 19, 2013
JulianGindimannequin
on Dec 19, 2013
Mannequin
More actions
I have not started yet, wasn't completely sure of the status of this. I'll get going filling in those tests to the best of my ability.
zware commented on Dec 19, 2013
zware
on Dec 19, 2013
MemberAuthor
More actions
Alright, sounds good.
JulianGindi commented on Dec 23, 2013
JulianGindimannequin
on Dec 23, 2013
Mannequin
More actions
So, it seems that there are many seemingly redundant tests and many tests whose intentions are unclear. I think this might be better suited for someone who has more experience with the xml minidom module. I have uploaded the work I have done but it is not complete.
19 remaining items
hugovk
added a commit that references this issue on Apr 26, 2025
gh-63882: Implement some `test_minidom` tests (#132879)
ee033d4
miss-islington
added a commit that references this issue on Apr 26, 2025
pythongh-63882: Implement some `test_minidom` tests (pythonGH-132879)
0496125
hugovk
added a commit that references this issue on Apr 26, 2025
[3.13] gh-63882: Implement some `test_minidom` tests (GH-132879) (#13…
fdcaaad
hugovk
added a commit that references this issue on May 5, 2025
gh-63882: Break down `and` tests in `test_minidom` (#133026)
e294e16
miss-islington
added a commit that references this issue on May 5, 2025
pythongh-63882: Break down `and` tests in `test_minidom` (pythonGH-13…
906a6d6
hugovk
added a commit that references this issue on May 5, 2025
[3.13] gh-63882: Break down `and` tests in `test_minidom` (GH-133026) (…
d84a762
srinivasreddy
added a commit that references this issue on May 13, 2025
Merge branch 'main' into pythongh-63882-doc_strings
c68cb4d
Pranjal095
added a commit that references this issue on Jul 12, 2025
pythongh-63882: Break down `and` tests in `test_minidom` (python#133026)
7677686
serhiy-storchaka
added a commit that references this issue on Sep 13, 2026
gh-63882: Implement empty tests in test_minidom (GH-156677)
f154574
johnslavik
added a commit that references this issue on Sep 14, 2026
pythongh-63882: Implement empty tests in test_minidom (pythonGH-156677)
b30ff9c
serhiy-storchaka
added 2 commits that reference this issue on Sep 14, 2026
[3.13] gh-63882: Implement empty tests in test_minidom (GH-156677) (G…
c698c63
[3.14] gh-63882: Implement empty tests in test_minidom (GH-156677) (G…
a4f6216
hugovk
added a commit that references this issue on Sep 15, 2026
[3.15] gh-63882: Implement empty tests in test_minidom (GH-156677) (#…
04347ef
zware commented on Oct 9, 2026
zware
on Oct 9, 2026
MemberAuthor
More actions
13 years later, this has been finished! Thanks to all, and especially @serhiy-storchaka for finally getting it over the finish line.
Reacted by Terry Jan Reedy and Hugo van Kemenade
zware
closed this as completed on Oct 9, 2026

Metadata

Assignees

No one assigned

Labels

easytestsTests in the Lib/test dirTests in the Lib/test dirtopic-XMLtype-featureA feature request or enhancementA feature request or enhancement

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

test_minidom has many empty tests #63882

Description

Linked PRs

Activity

zware commented on Nov 21, 2013

bitdancer commented on Nov 21, 2013

zware commented on Nov 21, 2013

ajiteshgupta commented on Nov 30, 2013

serhiy-storchaka commented on Nov 30, 2013

bitdancer commented on Nov 30, 2013

JulianGindi commented on Dec 5, 2013

python-dev commented on Dec 19, 2013

zware commented on Dec 19, 2013

JulianGindi commented on Dec 19, 2013

zware commented on Dec 19, 2013

JulianGindi commented on Dec 23, 2013

19 remaining items

zware commented on Oct 9, 2026

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions