GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-38250: [Enum] only include .rst test if file available by ethanfurman · Pull Request #24342 · python/cpython

Conversation

@ethanfurman

@ethanfurman ethanfurman commented Jan 26, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

In order to ensure the ReST documentation is up to date for Enum,
use doctest to check it -- but only if the .rst files have not
been stripped.

https://bugs.python.org/issue38250

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ethanfurman
[Enum] only include .rst test if file available
c92fb20 
In order to ensure the ReST documentation is up to date for Enum,
use doctest to check it -- but only if the .rst files have not
been stripped.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 26, 2021
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jan 26, 2021
vstinner
vstinner reviewed Jan 26, 2021
View reviewed changes
Comment thread Lib/test/test_enum.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ethanfurman
run __doc__ tests
970a5b2
@ethanfurman ethanfurman added the skip news label Jan 26, 2021
@ethanfurman
ethanfurman merged commit 01faf45 into python:master Jan 26, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Jan 26, 2021
@ethanfurman
ethanfurman deleted the enum-rst_test branch January 26, 2021 20:53
@vstinner

vstinner commented Jan 26, 2021

Copy link
Copy Markdown
Member

Thanks for keeping tests.addTests(doctest.DocTestSuite(enum)) ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@ethanfurman @adorilson
bpo-38250: [Enum] only include .rst test if file available (pythonGH-…
65576b9 
…24342)

* [Enum] only include .rst test if file available

In order to ensure the ReST documentation is up to date for Enum,
use doctest to check it -- but only if the .rst files have not
been stripped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ethanfurman @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.