GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-42773: fix tests not being run on pushes (GH-24004) by miss-islington · Pull Request #24437 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 3, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns [email protected]
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns [email protected]

https://bugs.python.org/issue42773

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@FFY00 @miss-islington
bpo-42773: fix tests not being run on pushes (pythonGH-24004)
6840cdf 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns <[email protected]>
@bedevere-bot bedevere-bot added the skip news label Feb 3, 2021
@bedevere-bot bedevere-bot mentioned this pull request Feb 3, 2021
bpo-42773: fix tests not being run on pushes #24004
Merged
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 3, 2021
@miss-islington

miss-islington commented Feb 3, 2021

Copy link
Copy Markdown
Contributor Author

@FFY00: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Feb 3, 2021
@miss-islington

miss-islington commented Feb 3, 2021

Copy link
Copy Markdown
Contributor Author

@FFY00: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
2 similar comments
@miss-islington

miss-islington commented Feb 3, 2021

Copy link
Copy Markdown
Contributor Author

@FFY00: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Feb 3, 2021

Copy link
Copy Markdown
Contributor Author

@FFY00: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Mariatta
Mariatta approved these changes Feb 3, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 3, 2021
@miss-islington

miss-islington commented Feb 3, 2021

Copy link
Copy Markdown
Contributor Author

@FFY00: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit d29dbb1 into python:3.8 Feb 3, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 3, 2021
@miss-islington
miss-islington deleted the backport-4ac923f-3.8 branch February 3, 2021 23:34
@miss-islington

miss-islington commented Feb 4, 2021

Copy link
Copy Markdown
Contributor Author

@FFY00: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @Mariatta @the-knights-who-say-ni @bedevere-bot @FFY00
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.