GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42773: fix tests not being run on pushes by FFY00 · Pull Request #24004 · python/cpython

Conversation

@FFY00

@FFY00 FFY00 commented Dec 29, 2020 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns [email protected]

https://bugs.python.org/issue42773

Automerge-Triggered-By: GH:Mariatta

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 29, 2020
@bedevere-bot bedevere-bot added the awaiting review label Dec 29, 2020
@Mariatta Mariatta added the skip news label Dec 30, 2020
Mariatta
Mariatta approved these changes Dec 30, 2020
View reviewed changes

@Mariatta Mariatta left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. I think the news file is not needed though. Would you be able to remove it. I have already applied the "skip news" label.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Dec 30, 2020
@FFY00
bpo-42773: fix tests not being run on pushes
f0d4699 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <[email protected]>
@FFY00
FFY00 force-pushed the bpo-42773 branch from fd314e5 to f0d4699 Compare December 30, 2020 12:49
@FFY00

FFY00 commented Dec 30, 2020

Copy link
Copy Markdown
Member Author

Done 😊
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta Mariatta added the 🤖 automerge label Dec 30, 2020
@miss-islington
miss-islington merged commit 4ac923f into python:master Dec 30, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 30, 2020
@Mariatta

Mariatta commented Dec 30, 2020

Copy link
Copy Markdown
Member

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta Mariatta added needs backport to 3.8 labels Dec 30, 2020
@miss-islington

miss-islington commented Dec 30, 2020

Copy link
Copy Markdown
Contributor

Thanks @FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Dec 30, 2020

Copy link
Copy Markdown
Contributor

Thanks @FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Dec 30, 2020
@bedevere-bot

bedevere-bot commented Dec 30, 2020

Copy link
Copy Markdown

GH-24010 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 30, 2020
@FFY00 @miss-islington
bpo-42773: fix tests not being run on pushes (pythonGH-24004)
477088f 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns <[email protected]>
@bedevere-bot

bedevere-bot commented Dec 30, 2020

Copy link
Copy Markdown

GH-24011 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Dec 30, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 30, 2020
@FFY00 @miss-islington
bpo-42773: fix tests not being run on pushes (pythonGH-24004)
4627140 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns <[email protected]>
@Mariatta Mariatta added needs backport to 3.8 labels Feb 3, 2021
@miss-islington

miss-islington commented Feb 3, 2021

Copy link
Copy Markdown
Contributor

Thanks @FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Feb 3, 2021

Copy link
Copy Markdown
Contributor

Thanks @FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Feb 3, 2021

Copy link
Copy Markdown

GH-24437 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Feb 3, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2021
@FFY00 @miss-islington
bpo-42773: fix tests not being run on pushes (pythonGH-24004)
6840cdf 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2021
@FFY00 @miss-islington
bpo-42773: fix tests not being run on pushes (pythonGH-24004)
8d86caf 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns <[email protected]>
@bedevere-bot

bedevere-bot commented Feb 3, 2021

Copy link
Copy Markdown

GH-24438 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Feb 3, 2021
miss-islington added a commit that referenced this pull request Feb 3, 2021
@miss-islington @FFY00
bpo-42773: fix tests not being run on pushes (GH-24004)
d29dbb1 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns <[email protected]>
miss-islington added a commit that referenced this pull request Feb 3, 2021
@miss-islington @FFY00
bpo-42773: fix tests not being run on pushes (GH-24004)
0898dcb 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@FFY00 @adorilson
bpo-42773: fix tests not being run on pushes (pythonGH-24004)
95bf79e 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request May 5, 2022
[3.7] gh-80254: Disallow recursive usage of cursors in sqlite3 converters #92334
Merged
@JelleZijlstra JelleZijlstra added the needs backport to 3.7 label May 5, 2022
@miss-islington

miss-islington commented May 5, 2022

Copy link
Copy Markdown
Contributor

Thanks @FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label May 5, 2022
@bedevere-bot

bedevere-bot commented May 5, 2022

Copy link
Copy Markdown

GH-92341 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 5, 2022
@FFY00 @miss-islington
bpo-42773: fix tests not being run on pushes (pythonGH-24004)
86dd591 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns <[email protected]>
ned-deily pushed a commit that referenced this pull request May 6, 2022
@miss-islington
bpo-42773: fix tests not being run on pushes (GH-24004) (GH-92341)
5adef3d 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 4ac923f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@FFY00 @Mariatta @miss-islington @bedevere-bot @JelleZijlstra @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.