GeezerVison is showing github.com — [3.9] bpo-42773: fix tests not being run on pushes (GH-24004) by miss-islington · Pull Request #24438 · python/cpython
Conversation
miss-islington
commented
Feb 3, 2021
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.
Signed-off-by: Filipe Laíns [email protected]
(cherry picked from commit 4ac923f)
Co-authored-by: Filipe Laíns [email protected]
https://bugs.python.org/issue42773
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.
Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 4ac923f)
Co-authored-by: Filipe Laíns <[email protected]>
|
@FFY00: Status check is done, and it's a success ✅ .
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@FFY00: Status check is done, and it's a success ✅ .
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@FFY00: Status check is done, and it's a success ✅ .
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@FFY00: Status check is done, and it's a success ✅ .
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
Mariatta
Mariatta approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|