GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [WIP] gh-81040: use sqlite3_stmt_readonly() to detect DML statements by erlend-aasland · Pull Request #24492 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Feb 9, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #81040

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner February 9, 2021 14:38
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 9, 2021
@bedevere-bot bedevere-bot added the awaiting review label Feb 9, 2021
@erlend-aasland

erlend-aasland commented Feb 9, 2021

Copy link
Copy Markdown
Contributor Author

Cherry-picked from #13216 and rebased onto master.

cc. @berkerpeksag @coleifer @serhiy-storchaka
coleifer reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
coleifer and others added 10 commits March 2, 2021 10:13
@coleifer Erlend E. Aasland
Use sqlite3_stmt_readonly API to determine is statement is DML.
11e9829
@coleifer Erlend E. Aasland
Skip dml detection + sql comment for old sqlite.
29a7e20
@coleifer Erlend E. Aasland
Add news item.
f20d41b
@coleifer Erlend E. Aasland
Address review comments, additional regression test.
868b97a
@berkerpeksag Erlend E. Aasland
Fix rest markup
a13fb71
@berkerpeksag Erlend E. Aasland
cosmetic fixes
6e1cf06
@coleifer Erlend E. Aasland
Ensure all non-DML statements that write are covered.
013e43b
@coleifer Erlend E. Aasland
Move DML detection tests into transactions test module.
6e6f2a0 
Also add additional assertion covering ALTER statements.
@coleifer Erlend E. Aasland
Fix version-check for sqlite3_stmt_readonly availability.
09cac6c 
Feature added in sqlite 3.7.4, not .11.
Erlend E. Aasland
Sync with pythonGH-24106
d1efa55
@erlend-aasland
erlend-aasland marked this pull request as draft March 2, 2021 09:15
@github-actions

github-actions Bot commented Apr 2, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 2, 2021
@erlend-aasland erlend-aasland changed the title bpo-36859: use sqlite3_stmt_readonly() to detect DML statements [WIP] bpo-36859: use sqlite3_stmt_readonly() to detect DML statements May 18, 2021
Erlend E. Aasland added 2 commits June 5, 2021 21:00
Erlend E. Aasland
Merge branch 'main' into bpo-36859
3645ccc
Erlend E. Aasland
PEP 7
dce7ada
@erlend-aasland
erlend-aasland force-pushed the bpo-36859 branch 3 times, most recently from ba8d1e6 to dce7ada Compare June 5, 2021 21:27
Erlend E. Aasland added 3 commits June 8, 2021 22:36
Erlend E. Aasland
Merge branch 'main' into bpo-36859
7c01d5a
Erlend E. Aasland
Improve namespace
6eb6ec9
Erlend E. Aasland
Merge branch 'main' into bpo-36859
1bdefdd
MaxwellDupre
MaxwellDupre suggested changes Apr 4, 2022
View reviewed changes

@MaxwellDupre MaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran 18 tests in 0.481s
OK
Other Sqlite tests also passed. Looks ok.
Need to add to Docs, not just NEWS otherwise users will not be aware.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Apr 4, 2022
@erlend-aasland erlend-aasland changed the title [WIP] bpo-36859: use sqlite3_stmt_readonly() to detect DML statements [WIP] gh-81040: use sqlite3_stmt_readonly() to detect DML statements Apr 10, 2022
@coleifer coleifer mannequin mentioned this pull request May 16, 2022
sqlite3 dml statement detection does not account for CTEs #81040
Closed
@erlend-aasland

erlend-aasland commented Jun 27, 2022

Copy link
Copy Markdown
Contributor Author

I'm not sure this is the correct way to address to the problems in the linked issue. Closing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland closed this Jun 27, 2022
@erlend-aasland
erlend-aasland deleted the bpo-36859 branch June 27, 2022 08:01
@coleifer coleifer mentioned this pull request Jun 26, 2023
Autocommit behaves differently from sqlite3 coleifer/pysqlite3#58
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
1 more reviewer
@MaxwellDupre MaxwellDupre MaxwellDupre requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sqlite3 dml statement detection does not account for CTEs

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@erlend-aasland @MaxwellDupre @the-knights-who-say-ni @bedevere-bot @coleifer @berkerpeksag
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.