GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40810: Require SQLite 3.7.15 by erlend-aasland · Pull Request #24106 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jan 4, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Remove code required to support SQLite pre 3.7.15.

https://bugs.python.org/issue40810

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner January 4, 2021 23:31
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 4, 2021
@bedevere-bot bedevere-bot added the awaiting review label Jan 4, 2021
@erlend-aasland
erlend-aasland force-pushed the require-sqlite-3.7.15 branch from 3a9c473 to f80d5bc Compare January 4, 2021 23:53
@erlend-aasland

erlend-aasland commented Jan 4, 2021

Copy link
Copy Markdown
Contributor Author

@berkerpeksag Would you mind reviewing this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes Jan 5, 2021
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, SQLite 3.7.15 was released 8 years ago, so I think we are safe to bump the minimal required version. But please wait for confirmation of other core developer.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jan 5, 2021
Erlend E. Aasland
bpo-40810: Require SQLite 3.7.15
93372c0 
Remove code required to support SQLite pre 3.7.15.
@erlend-aasland
erlend-aasland force-pushed the require-sqlite-3.7.15 branch from f80d5bc to 93372c0 Compare January 5, 2021 08:45
@erlend-aasland

erlend-aasland commented Jan 5, 2021

Copy link
Copy Markdown
Contributor Author

Thanks, @serhiy-storchaka! If you've got a suggestion for another core dev that'd be interested in reviewing this, please feel free to request their review.

FYI, rebased onto master for the #24110 NEWS item fix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jan 5, 2021

Copy link
Copy Markdown
Contributor Author

@pablogsal Would you mind reviewing this? (Ref. your review of #20909)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
berkerpeksag
berkerpeksag approved these changes Jan 6, 2021
View reviewed changes

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd prefer stick to 3.7.15 for a while. I feel like we are getting a bit carried away with dropping support for older SQLite versions :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@berkerpeksag
berkerpeksag merged commit cf0b239 into python:master Jan 6, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 6, 2021
@erlend-aasland

erlend-aasland commented Jan 6, 2021

Copy link
Copy Markdown
Contributor Author

LGTM, but I'd prefer stick to 3.7.15 for a while. I feel like we are getting a bit carried away with dropping support for older SQLite versions :)

Sure, I agree :) There's not too much support code laying around now, so I think we can stay at 3.7.15 for now. Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland deleted the require-sqlite-3.7.15 branch January 6, 2021 00:08
@erlend-aasland erlend-aasland mentioned this pull request Jan 10, 2021
bpo-36859: Use sqlite3_stmt_readonly API when possible to determine if statement is DML.K #13216
Closed
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Feb 24, 2021
Erlend E. Aasland
bpo-43314: Remove SQLITE_OPEN_URI ifdef
14e9ce9 
SQLite 3.7.15 is required as by pythonGH-24106. SQLITE_OPEN_URI was added in
SQLite 3.7.7.
@erlend-aasland erlend-aasland mentioned this pull request Feb 24, 2021
bpo-43314: Remove pre SQLite 3.7.7 support code for SQLITE_OPEN_URI #24637
Merged
berkerpeksag pushed a commit that referenced this pull request Feb 26, 2021
Erlend Egeberg Aasland
bpo-43314: Remove SQLITE_OPEN_URI ifdef (GH-24637)
3150754 
SQLite 3.7.15 is required as by GH-24106. SQLITE_OPEN_URI was added in
SQLite 3.7.7.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland @adorilson
bpo-40810: Require SQLite 3.7.15 (pythonGH-24106)
b8fc2b2
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland @adorilson
bpo-43314: Remove SQLITE_OPEN_URI ifdef (pythonGH-24637)
1176a2a 
SQLite 3.7.15 is required as by pythonGH-24106. SQLITE_OPEN_URI was added in
SQLite 3.7.7.
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jun 5, 2021
Erlend E. Aasland
Sync with pythonGH-24106
d1efa55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @berkerpeksag @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.