GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-40956: [regression] first argument in sqlite3.Connection.backup is mandatory by erlend-aasland · Pull Request #24503 · python/cpython

Conversation

erlend-aasland commented Feb 10, 2021 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Regression introduced by GH-23838.

https://bugs.python.org/issue40956

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          First argument of sqlite3.Connection.backup is mandatory

7e9dadd

erlend-aasland requested a review from berkerpeksag as a code owner

February 10, 2021 20:54

the-knights-who-say-ni added the CLA signed label

Feb 10, 2021

bedevere-bot added the awaiting review label

Feb 10, 2021

erlend-aasland commented Feb 10, 2021

Copy link

Copy Markdown

Contributor Author

@berkerpeksag would you please review?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented Feb 10, 2021

Copy link

Copy Markdown

Contributor Author

skip news

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

berkerpeksag requested changes

Feb 10, 2021

View reviewed changes

berkerpeksag left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test case to confirm that the regression is fixed by this?

You can rename test_bad_target_none to test_bad_target and add the new test here:

cpython/Lib/sqlite3/test/backup.py

Lines 20 to 22 in 749d40a

	def test_bad_target_none(self):
	with self.assertRaises(TypeError):
	self.cx.backup(None)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot removed the awaiting review label

Feb 10, 2021

bedevere-bot commented Feb 10, 2021

Copy link

Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added the awaiting changes label

Feb 10, 2021

berkerpeksag commented Feb 10, 2021

Copy link

Copy Markdown

Member

And this is actually need a NEWS entry because the previous PR has already been released in 3.10 alphas.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented Feb 10, 2021

Copy link

Copy Markdown

Contributor Author

Could you please add a test case to confirm that the regression is fixed by this?

Sure, I'll do it first thing tomorrow.

And this is actually need a NEWS entry because the previous PR has already been released in 3.10 alphas.

I see. Thanks for the heads-up.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented Feb 10, 2021

Copy link

Copy Markdown

Contributor Author

BTW, will you have time to review #24203 and #24421 any time soon?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Address review: add test

6a3f3b4

berkerpeksag commented Feb 10, 2021

Copy link

Copy Markdown

Member

BTW, will you have time to review #24203 and #24421 any time soon?

I'm on holidays at the moment so will see :) They are definitely on my TODO list, though.

erlend-aasland reacted with hooray emoji

All reactions

🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Add NEWS

da330e8

erlend-aasland commented Feb 10, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

BTW, will you have time to review #24203 and #24421 any time soon?

I'm on holidays at the moment so will see :) They are definitely on my TODO list, though.

Oops, sorry! Enjoy your days off :) Thanks!

(I have made the requested changes; please review again)

BTW, not sure about the NEWS entry. It felt a bit clumsy. Let me know if you want me to rephrase it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting change review and removed awaiting changes labels

Feb 10, 2021

bedevere-bot commented Feb 10, 2021

Copy link

Copy Markdown

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot requested a review from berkerpeksag

February 10, 2021 22:33


          use meth

105aa2c

berkerpeksag approved these changes

Feb 10, 2021

View reviewed changes

berkerpeksag left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with hooray emoji

All reactions

🎉 1 reaction

bedevere-bot added awaiting merge and removed awaiting change review labels

Feb 10, 2021

erlend-aasland commented Feb 10, 2021

Copy link

Copy Markdown

Contributor Author

Thanks, @berkerpeksag 🙏🏻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

berkerpeksag merged commit ea46579 into python:master

Feb 10, 2021

bedevere-bot removed the awaiting merge label

Feb 10, 2021

sthagen mentioned this pull request

Feb 11, 2021

bpo-40956: Fix segfault when Connection.backup is called without targ… sthagen/python-cpython#384

Merged

erlend-aasland deleted the sqlite-fix-backup branch

February 11, 2021 08:02

berkerpeksag mentioned this pull request

Feb 21, 2021

bpo-40956: Convert sqlite3.connect and sqlite3.Connection.__init__ to AC #24421

Merged

adorilson pushed a commit to adorilson/cpython that referenced this pull request

Mar 13, 2021


          bpo-40956: Fix segfault when Connection.backup is called without targ…

1bb6281

…et (pythonGH-24503)

Reviewers

berkerpeksag

berkerpeksag approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented Feb 10, 2021 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented Feb 10, 2021

Uh oh!

erlend-aasland commented Feb 10, 2021

Uh oh!

berkerpeksag left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Feb 10, 2021

Uh oh!

berkerpeksag commented Feb 10, 2021

Uh oh!

erlend-aasland commented Feb 10, 2021

Uh oh!

erlend-aasland commented Feb 10, 2021

Uh oh!

berkerpeksag commented Feb 10, 2021

Uh oh!

erlend-aasland commented Feb 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Feb 10, 2021

Uh oh!

berkerpeksag left a comment

Choose a reason for hiding this comment

Uh oh!

erlend-aasland commented Feb 10, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

erlend-aasland commented Feb 10, 2021 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented Feb 10, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.