GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-35134: Move Include/{pyarena.h,pyctype.h} to Include/cpython by nw0 · Pull Request #24550 · python/cpython

Conversation

@nw0

@nw0 nw0 commented Feb 16, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Move non-limited C API headers pyarena.h, pyctype.h into
Include/cpython.

In the same vein as previous PRs by @vstinner.

https://bugs.python.org/issue35134

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nw0
Move Include/{pyarena.h,pyctype.h} to Include/cpython
ba11be5 
Move non-limited C API headers pyarena.h, pyctype.h into
Include/cpython.
@nw0
nw0 requested review from a team, lysnikolaou and pablogsal as code owners February 16, 2021 14:13
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 16, 2021
@bedevere-bot bedevere-bot added the awaiting review label Feb 16, 2021
@pablogsal
pablogsal requested a review from vstinner February 16, 2021 14:16
@vstinner

vstinner commented Feb 16, 2021

Copy link
Copy Markdown
Member

Can you please add a NEWS entry in the C API to mention that pytime.h, pyarena.h and pyctype.h headers were moved into the cpython/ directory and must not be included directly: they are already included by Python.h.

You can add a :ref:`Include Files <api-includes>` link to https://docs.python.org/dev/c-api/intro.html#include-files.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nw0
update NEWS
1e16b15
@nw0

nw0 commented Feb 17, 2021

Copy link
Copy Markdown
Contributor Author

Can you please add a NEWS entry in the C API to mention that pytime.h, pyarena.h and pyctype.h headers were moved into the cpython/ directory and must not be included directly: they are already included by Python.h.

You can add a :ref:`Include Files <api-includes>` link to https://docs.python.org/dev/c-api/intro.html#include-files.

Updated. Thanks for your review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 366dc3a into python:master Feb 17, 2021
@bedevere-bot bedevere-bot removed the awaiting review label Feb 17, 2021
@vstinner

vstinner commented Feb 17, 2021

Copy link
Copy Markdown
Member

Merged, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@nw0 @adorilson
bpo-35134: Move Include/{pyarena.h,pyctype.h} to Include/cpython/ (py…
3953750 
…thonGH-24550)

Move non-limited C API headers pyarena.h and pyctype.h
into Include/cpython/ directory.
@vstinner vstinner mentioned this pull request Apr 10, 2022
Add a new Include/cpython/ subdirectory for the "CPython API" with implementation details #79315
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou
@pablogsal pablogsal Awaiting requested review from pablogsal
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@nw0 @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.