GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.5] bpo-13617: Reject embedded null characters in wchar* strings. (GH-2302) by serhiy-storchaka · Pull Request #2463 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 28, 2017

Copy link
Copy Markdown
Member

Based on patch by Victor Stinner.

Add private C API function _PyUnicode_AsUnicode() which is similar to
PyUnicode_AsUnicode(), but checks for null characters..
(cherry picked from commit f7eae0a)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
[3.5] [security] bpo-13617: Reject embedded null characters in wchar*…
dc607df 
… strings. (pythonGH-2302)

Based on patch by Victor Stinner.

Add private C API function _PyUnicode_AsUnicode() which is similar to
PyUnicode_AsUnicode(), but checks for null characters..
(cherry picked from commit f7eae0a)
@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Jun 28, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 28, 2017
@bedevere-bot bedevere-bot mentioned this pull request Jun 28, 2017
[security] bpo-13617: Reject embedded null characters in wchar* strings. #2302
Merged
@serhiy-storchaka serhiy-storchaka changed the title [3.5] [security] bpo-13617: Reject embedded null characters in wchar* strings. (GH-2302) [3.5] bpo-13617: Reject embedded null characters in wchar* strings. (GH-2302) Jun 28, 2017
serhiy-storchaka added 5 commits June 28, 2017 09:19
@serhiy-storchaka
Fix test_builtin.
392ed3b
@serhiy-storchaka
Fix compiler warnings.
0e8b404
@serhiy-storchaka
Fix a compiler warning.
a4543dd
@serhiy-storchaka
Fix test_winsound.
5581617
@serhiy-storchaka
Fix test_builtin on Windows.
57bab4c
@serhiy-storchaka
serhiy-storchaka merged commit 54ba940 into python:3.5 Jun 28, 2017
@serhiy-storchaka
serhiy-storchaka deleted the backport-f7eae0a-3.5 branch June 28, 2017 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.