GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [security] bpo-13617: Reject embedded null characters in wchar* strings. by serhiy-storchaka · Pull Request #2302 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 20, 2017

Copy link
Copy Markdown
Member

Based on patch by Victor Stinner.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka serhiy-storchaka added needs backport to 3.5 type-bug An unexpected behavior, bug, or error type-security A security issue labels Jun 20, 2017
@serhiy-storchaka
serhiy-storchaka requested a review from vstinner June 20, 2017 15:39
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 20, 2017
@mention-bot

mention-bot commented Jun 20, 2017

Copy link
Copy Markdown

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loewis, @akuchling and @theller to be potential reviewers.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka force-pushed the reject-null-wchars branch from 04958f5 to 9ed8d7b Compare June 21, 2017 03:41
serhiy-storchaka added 13 commits June 23, 2017 19:13
@serhiy-storchaka
bpo-13617: Reject embedded null characters in wchar* strings.
040cef8 
Original patch by Victor Stinner.
@serhiy-storchaka
Fix tests.
a3b4f58
@serhiy-storchaka
Fix compiler warnings.
b566322
@serhiy-storchaka
Change exceptions type to ValueError.
d5d331c
@serhiy-storchaka
Add more checks.
89f4c4a
@serhiy-storchaka
Fix compiler warnings on Windows.
74b1e6e
@serhiy-storchaka
Add more checks in the _curses module.
13afbe0
@serhiy-storchaka
Fix check in the _locale module.
970da5e
@serhiy-storchaka
Add _PyUnicode_AsUnicode() and simplifies the code.
0b3d03e
@serhiy-storchaka
Fix a regression in the array module.
b0ac383
@serhiy-storchaka
Fix compiler errors and warnings on Windows.
3159da9
@serhiy-storchaka
Fix _winapi.CreateProcess().
fd2d9c7
@serhiy-storchaka
Make test_imp more lenient.
c26138c
@serhiy-storchaka
serhiy-storchaka force-pushed the reject-null-wchars branch from 9ed8d7b to c26138c Compare June 23, 2017 16:16
serhiy-storchaka added 3 commits June 23, 2017 21:45
@serhiy-storchaka
Merge branch 'master' into reject-null-wchars
1f53f97
@serhiy-storchaka
Merge branch 'master' into reject-null-wchars
d2f85b4
@serhiy-storchaka
Withdraw redundant checks.
69fc150
@vstinner vstinner changed the title bpo-13617: Reject embedded null characters in wchar* strings. [security] bpo-13617: Reject embedded null characters in wchar* strings. Jun 28, 2017
serhiy-storchaka added 3 commits June 28, 2017 07:52
@serhiy-storchaka
Add more tests.
5db31e0
@serhiy-storchaka
Withdraw changes in the array module.
66a8f18
@serhiy-storchaka
Merge branch 'master' into reject-null-wchars
a2bb3bc
@serhiy-storchaka
serhiy-storchaka merged commit f7eae0a into python:master Jun 28, 2017
@serhiy-storchaka
serhiy-storchaka deleted the reject-null-wchars branch June 28, 2017 05:30
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jun 28, 2017
@serhiy-storchaka
[3.6] [security] bpo-13617: Reject embedded null characters in wchar*…
d786e3b 
… strings. (pythonGH-2302)

Based on patch by Victor Stinner.

Add private C API function _PyUnicode_AsUnicode() which is similar to
PyUnicode_AsUnicode(), but checks for null characters..
(cherry picked from commit f7eae0a)
@bedevere-bot

bedevere-bot commented Jun 28, 2017

Copy link
Copy Markdown

GH-2462 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Jun 28, 2017
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jun 28, 2017
@serhiy-storchaka
[3.5] [security] bpo-13617: Reject embedded null characters in wchar*…
dc607df 
… strings. (pythonGH-2302)

Based on patch by Victor Stinner.

Add private C API function _PyUnicode_AsUnicode() which is similar to
PyUnicode_AsUnicode(), but checks for null characters..
(cherry picked from commit f7eae0a)
@bedevere-bot

bedevere-bot commented Jun 28, 2017

Copy link
Copy Markdown

GH-2463 is a backport of this pull request to the 3.5 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.5 label Jun 28, 2017
serhiy-storchaka added a commit that referenced this pull request Jun 28, 2017
@serhiy-storchaka
[3.6] bpo-13617: Reject embedded null characters in wchar* strings. (G…
0834905 
…H-2302) (#2462)

Based on patch by Victor Stinner.

Add private C API function _PyUnicode_AsUnicode() which is similar to
PyUnicode_AsUnicode(), but checks for null characters..
(cherry picked from commit f7eae0a)
serhiy-storchaka added a commit that referenced this pull request Jun 28, 2017
@serhiy-storchaka
[3.5] bpo-13617: Reject embedded null characters in wchar* strings. (G…
54ba940 
…H-2302) (#2463)

Based on patch by Victor Stinner.

Add private C API function _PyUnicode_AsUnicode() which is similar to
PyUnicode_AsUnicode(), but checks for null characters..
(cherry picked from commit f7eae0a)
@vifon vifon mentioned this pull request Dec 16, 2017
Ranger crash on m3u file ranger/ranger#990
Closed
@KeyWeeUsr KeyWeeUsr mentioned this pull request Jan 18, 2018
Fix Ctypes Clipboard error with embeded null character kivy/kivy#5579
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @mention-bot @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.