GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29585: Fix Windows build failure by methane · Pull Request #2476 · python/cpython

Conversation

@methane

@methane methane commented Jun 28, 2017

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane
bpo-29585: Fix Windows build failure
3e645f2
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 28, 2017
vstinner
vstinner reviewed Jun 28, 2017
View reviewed changes
Comment thread PC/pyconfig.h

/* framework name */
#define PYTHONFRAMEWORK ""

@vstinner vstinner Jun 28, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis CI failed:

Fixing C file whitespace ... 1 file:

PC/pyconfig.h

Fixing docs whitespace ... 0 files

Please fix the 1 file(s) with whitespace issues

(on UNIX you can run make patchcheck to make the fixes)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner

vstinner commented Jun 28, 2017

Copy link
Copy Markdown
Member

@methane didn't update his PR fast enough, and I don't know if I'm allowed to modify this PR, so I created mine: PR #2477. I would like to repair the buildbots as soon as possible!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Jun 28, 2017
bpo-29585: optimize site.py startup time #136
Merged
@methane methane closed this Jun 28, 2017
@methane
methane deleted the optimize-site-startup branch June 28, 2017 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@methane @vstinner @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.