GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29585: Define PYTHONFRAMEWORK in PC/pyconfig.h by vstinner · Pull Request #2477 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 28, 2017

Copy link
Copy Markdown
Member

Fix also PC/pyconfig.h whitespaces: run "make patchcheck".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vstinner added 2 commits June 28, 2017 17:59
@vstinner
bpo-29585: Fix PC/pyconfig.h whitespaces
46beabc 
Run "make patchcheck".
@vstinner
bpo-29585: Define PYTHONFRAMEWORK in PC/pyconfig.h
7dfe17d
@vstinner
vstinner requested a review from methane June 28, 2017 16:02
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 28, 2017
This was referenced Jun 28, 2017
bpo-29585: Fix Windows build failure #2476
Closed
bpo-29585: optimize site.py startup time #136
Merged
@vstinner

vstinner commented Jun 28, 2017

Copy link
Copy Markdown
Member Author

Crap. Tests fail on Windows:

======================================================================
FAIL: test_get_path (test.test_site.HelperFunctionsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\projects\cpython\lib\test\test_site.py", line 188, in test_get_path
    sysconfig.get_path('purelib', os.name + '_user'))
AssertionError: 'C:\\Users\\appveyor\\AppData\\Roaming\\Python/Python37/site-packages' != 'C:\\Users\\appveyor\\AppData\\Roaming\\Python\\Python37\\site-packages'
- C:\Users\appveyor\AppData\Roaming\Python/Python37/site-packages
?                                         ^        ^
+ C:\Users\appveyor\AppData\Roaming\Python\Python37\site-packages
?                                         ^        ^
======================================================================
FAIL: test_s_option (test.test_site.HelperFunctionsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\projects\cpython\lib\test\test_site.py", line 195, in test_s_option
    self.assertIn(usersite, sys.path)
AssertionError: 'C:\\Users\\appveyor\\AppData\\Roaming\\Python/Python37/site-packages' not found in ['', 'C:\\projects\\cpython\\PCbuild\\win32\\python37.zip', 'C:\\projects\\cpython\\DLLs', 'C:\\projects\\cpython\\lib', 'C:\\projects\\cpython\\PCbuild\\win32', 'C:\\projects\\cpython', 'C:\\projects\\cpython\\lib\\site-packages']
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jun 28, 2017

Copy link
Copy Markdown
Member Author

This PR fixes a regression of the PR #136.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
site: Fix path separator in _get_path() on Windows
f5aa578
@vstinner
vstinner merged commit b01c574 into python:master Jun 28, 2017
@vstinner
vstinner deleted the win branch June 28, 2017 16:34
@vstinner vstinner mentioned this pull request Jun 28, 2017
Revert "bpo-29585: optimize site.py startup time" #2478
Closed
@methane

methane commented Jun 28, 2017

Copy link
Copy Markdown
Member

thanks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jun 28, 2017

Copy link
Copy Markdown
Member Author

thanks

You're welcome. I hesitated to just revert your PR to get more time to fix it, but at the end, I found a way to repair the Windows buildbots, so it's fine.

Hey, don't forget our macOS buildbots which are also broken!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane Awaiting requested review from methane

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @methane @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.