GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-35883: Py_DecodeLocale() escapes invalid Unicode characters (GH-24843) by miss-islington · Pull Request #24906 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Mar 17, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Python no longer fails at startup with a fatal error if a command
line argument contains an invalid Unicode character.

The Py_DecodeLocale() function now escapes byte sequences which would
be decoded as Unicode characters outside the [U+0000; U+10ffff]
range.

Use MAX_UNICODE constant in unicodeobject.c.
(cherry picked from commit 9976834)

Co-authored-by: Victor Stinner [email protected]

https://bugs.python.org/issue35883

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner @miss-islington
bpo-35883: Py_DecodeLocale() escapes invalid Unicode characters (pyth…
614e836 
…onGH-24843)

Python no longer fails at startup with a fatal error if a command
line argument contains an invalid Unicode character.

The Py_DecodeLocale() function now escapes byte sequences which would
be decoded as Unicode characters outside the [U+0000; U+10ffff]
range.

Use MAX_UNICODE constant in unicodeobject.c.
(cherry picked from commit 9976834)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Mar 17, 2021
bpo-35883: Py_DecodeLocale() escapes invalid Unicode characters #24843
Merged
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 17, 2021
@miss-islington

miss-islington commented Mar 17, 2021

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Mar 17, 2021
vstinner
vstinner approved these changes Mar 17, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 17, 2021
@vstinner
vstinner merged commit 3b6e61e into python:3.8 Mar 29, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 29, 2021
@miss-islington
miss-islington deleted the backport-9976834-3.8 branch March 29, 2021 19:36
@Neui Neui mannequin mentioned this pull request Apr 10, 2022
Python startup fails with a fatal error if a command line argument contains an invalid Unicode character #80064
Closed
pull Bot pushed a commit to Mu-L/bup that referenced this pull request Jul 2, 2026
@rlbdv
Raise minimum python from 3.7 to 3.8
cf087f5 
This should allow us to drop our custom argv (bytes) handling since
the underlying issue

  https://sourceware.org/bugzilla/show_bug.cgi?id=2373

appears to have been fixed upstream and then backported all the way to 3.8:

  614e836f6e934854c6bbf698d759e5cde607a629
  bpo-35883: Py_DecodeLocale() escapes invalid Unicode characters (GH-24843)
  python/cpython#24906

We can also count on having Py_BytesMain, and gain access to
assignment expressions and positional-only parameters.

Version 3.8's been available since 2019, and 3.7 is well past its
upstream EOL.

Signed-off-by: Rob Browning <[email protected]>
Tested-by: Rob Browning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.