GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43588: use static variable module under building Python with --with-experimental-isolated-subinterpreters cause crash. by dexterhahaha · Pull Request #24963 · python/cpython

Conversation

@dexterhahaha

@dexterhahaha dexterhahaha commented Mar 22, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

use static module variable under building Python with --with-experimental-isolated-subinterpreters cause crash.

compiler_mod(struct compiler *c, mod_ty mod)
{
    PyCodeObject *co;
    int addNone = 1;
    static PyObject *module;
    if (!module) {
        module = PyUnicode_InternFromString("<module>");
        if (!module)
            return NULL;
    }
...
}

https://bugs.python.org/issue43588

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dexterhahaha
dexterhahaha requested a review from markshannon as a code owner March 22, 2021 08:18
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 22, 2021
@bedevere-bot bedevere-bot added the awaiting review label Mar 22, 2021
xiejunyi
bpo-43588: use static variable module under building Python with --wi…
82463c5 
…th-experimental-isolated-subinterpreters cause crash.
@dexterhahaha

dexterhahaha commented Mar 22, 2021

Copy link
Copy Markdown
Contributor Author

Hello, this change seems might not need to update news.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Apr 22, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 22, 2021
@kumaraditya303

kumaraditya303 commented Apr 7, 2022

Copy link
Copy Markdown
Contributor

The static variable was removed in #31366 so closing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 kumaraditya303 closed this Apr 7, 2022
@JunyiXie JunyiXie mannequin mentioned this pull request Apr 10, 2022
[Subinterpreters]: use static variable under building Python with --with-experimental-isolated-subinterpreters cause crash. #87754
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@dexterhahaha @kumaraditya303 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.