GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46765: Replace Locally Cached Strings with Statically Initialized Objects by ericsnowcurrently · Pull Request #31366 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Feb 16, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue46765

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
ericsnowcurrently added 16 commits February 15, 2022 18:31
@ericsnowcurrently
Use _Py_ID() in boolobject.c.
fdf87ee
@ericsnowcurrently
Use _Py_ID() in classobject.c.
2c2f917
@ericsnowcurrently
Use _Py_ID() in codeobject.c.
5f2746b
@ericsnowcurrently
Drop outdated entries.
1df92a0
@ericsnowcurrently
Move an entry to the right section.
da9810b
@ericsnowcurrently
Drop an outdated entry.
b06e610
@ericsnowcurrently
Use _Py_ID() in listobject.c.
b8ea691
@ericsnowcurrently
Use _Py_ID() in _warnings.c.
42b714f
@ericsnowcurrently
Use _Py_ID() in ast_unparse.c.
c7c8faf
@ericsnowcurrently
Use _Py_ID() in compile.c.
92b0069
@ericsnowcurrently
Use _Py_ID() in symtable.c.
226671e
@ericsnowcurrently
Drop outdated entries.
3acf264
@ericsnowcurrently
Use _Py_ID() in sysmodule.c.
3a02502
@ericsnowcurrently
Use _Py_ID() in the _io module.
cd47553
@ericsnowcurrently
Use _Py_ID() in _tracemalloc.c.
f8b7071
@ericsnowcurrently
Drop an outdated entry.
76d2955
@ericsnowcurrently ericsnowcurrently added the skip news label Feb 16, 2022
@ericsnowcurrently
ericsnowcurrently requested a review from markshannon as a code owner February 16, 2022 03:18
@bedevere-bot bedevere-bot added the awaiting core review label Feb 16, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 16, 2022
@ericsnowcurrently
ericsnowcurrently removed the request for review from markshannon February 16, 2022 03:18
arhadthedev
arhadthedev reviewed Feb 16, 2022
View reviewed changes
Comment thread Objects/boolobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

ericsnowcurrently added 2 commits February 16, 2022 08:36
@ericsnowcurrently
Use b'', not ''.
02995b0
@ericsnowcurrently
Use a ternary expression.
efe208f
@ericsnowcurrently ericsnowcurrently mentioned this pull request Feb 16, 2022
Replace Locally Cached Strings with Statically Initialized Objects faster-cpython/ideas#286
Closed
@ericsnowcurrently ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 16, 2022
@bedevere-bot

bedevere-bot commented Feb 16, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit efe208f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 16, 2022
@ericsnowcurrently

ericsnowcurrently commented Feb 17, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Alrighty then! asyncio on Mac and refleaks...

# https://buildbot.python.org/all/#/builders/474/builds/435
test_email leaked [6, 6, 6] memory blocks, sum=18
test_fractions leaked [2, 2, 2] references, sum=6
test_http_cookies leaked [2, 2, 2] references, sum=6
test_property leaked [6, 6, 6] references, sum=18
test_tracemalloc leaked [1, 1, 1] references, sum=3
test_zoneinfo leaked [12, 12, 12] references, sum=36

# https://buildbot.python.org/all/#/builders/18/builds/447
test_email leaked [7, 6, 6] memory blocks, sum=19
test_fractions leaked [2, 2, 2] references, sum=6
test_http_cookies leaked [2, 2, 2] references, sum=6
test_property leaked [6, 6, 6] references, sum=18
test_tracemalloc leaked [1, 1, 1] references, sum=3
test_zoneinfo leaked [12, 12, 12] references, sum=36
+
test_importlib leaked [67, 63, 63] references, sum=193
test_importlib leaked [36, 34, 34] memory blocks, sum=104

# https://buildbot.python.org/all/#/builders/411/builds/436
test_email leaked [6, 6, 6] memory blocks, sum=18
test_fractions leaked [2, 2, 2] references, sum=6
test_http_cookies leaked [2, 2, 2] references, sum=6
test_property leaked [6, 6, 6] references, sum=18
test_tracemalloc leaked [1, 1, 1] references, sum=3
test_zoneinfo leaked [12, 12, 12] references, sum=36
+
test_typing leaked [1, 1, 1] memory blocks, sum=3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@markshannon

markshannon commented Feb 17, 2022

Copy link
Copy Markdown
Member

The asycnio test on Mac seems to be flaky. I've seen a failure on my PRs, which was fixed by re-running the tests.

The refleaks failures are puzzling. Are they passing on main?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ericsnowcurrently

ericsnowcurrently commented Feb 17, 2022

Copy link
Copy Markdown
Member Author

The asycnio test on Mac seems to be flaky. I've seen a failure on my PRs, which was fixed by re-running the tests.

I suspected that but wasn't sure. It failed on repeated CI runs and on that buildbot. So I as at least going to investigate further.

The refleaks failures are puzzling. Are they passing on main?

Hmm, looks like they weren't. So maybe I'm okay here. I'll have to re-run it after the refleaks fix lands.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Feb 17, 2022

Copy link
Copy Markdown
Contributor

Hmm, looks like they weren't. So maybe I'm okay here. I'll have to re-run it after the refleaks fix lands.

FYI, they landed with GH-31389 just recently.

ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ericsnowcurrently ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 17, 2022
@bedevere-bot

bedevere-bot commented Feb 17, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit efe208f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 17, 2022
@erlend-aasland

erlend-aasland commented Feb 17, 2022

Copy link
Copy Markdown
Contributor

I believe you will need to sync with main first:

$ git fetch --all
$ git merge --no-ff upstream/main
$ git push origin global-objects-use-pyid
ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ericsnowcurrently
Merge branch 'main' into global-objects-use-pyid
1852340
@ericsnowcurrently ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 18, 2022
@bedevere-bot

bedevere-bot commented Feb 18, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 1852340 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 18, 2022
@ericsnowcurrently ericsnowcurrently mentioned this pull request Feb 18, 2022
move cached strings to global objects faster-cpython/ideas#282
Closed
@ericsnowcurrently

ericsnowcurrently commented Feb 18, 2022

Copy link
Copy Markdown
Member Author

That looks better. I'm still going to double-check that macOS failure before merging.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ericsnowcurrently
ericsnowcurrently merged commit 1f45536 into python:main Feb 23, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Feb 23, 2022
@ericsnowcurrently
ericsnowcurrently deleted the global-objects-use-pyid branch February 23, 2022 00:23
@sweeneyde

sweeneyde commented Mar 2, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I tested ./python -m test test_decimal -R3:3 and got [1, 1, 1] reference leaks on main, and bisected that to here. Is there some reason why that could happen on my machine but not on buildbots? I tested on windows with MSVC and also on WSL.

1f455361ecfb1892e375bdbee813cdf095b6cfb8 is the first bad commit
commit 1f455361ecfb1892e375bdbee813cdf095b6cfb8
Author: Eric Snow <[email protected]>
Date:   Tue Feb 22 17:23:51 2022 -0700

    [bpo-46765](https://bugs.python.org/issue46765): Replace Locally Cached Strings with Statically Initialized Objects (gh-31366)

    https://bugs.python.org/issue46765
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ericsnowcurrently

ericsnowcurrently commented Mar 2, 2022

Copy link
Copy Markdown
Member Author

I'll take a look.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sweeneyde

sweeneyde commented Mar 3, 2022

Copy link
Copy Markdown
Member

Running git clean -f ended up fixing everything, so probably nothing to worry about.

ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Apr 7, 2022
bpo-43588: fix listobject.c use static variables under building under building Python with --with-experimental-isolated-subinterpreters may cause crash #24972
Closed
bpo-43588: fix _warnings.c static variables under building under building Python with --with-experimental-isolated-subinterpreters may cause crash #24971
Closed
bpo-43588: fix sysmodule.c use static variables under building under building Python with --with-experimental-isolated-subinterpreters may cause crash #24969
Closed
bpo-43588: fix boolobject.c static variables under building under building Python with --with-experimental-isolated-subinterpreters may cause crash #24966
Closed
bpo-43588: use static variable module under building Python with --with-experimental-isolated-subinterpreters cause crash. #24963
Closed
@kumaraditya303 kumaraditya303 mentioned this pull request Jul 24, 2022
[Subinterpreters]: use static variable under building Python with --with-experimental-isolated-subinterpreters cause crash. #87754
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@ericsnowcurrently @bedevere-bot @markshannon @erlend-aasland @sweeneyde @arhadthedev @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.