GeezerVison is showing github.com — bpo-46765: Replace Locally Cached Strings with Statically Initialized Objects by ericsnowcurrently · Pull Request #31366 · python/cpython
Conversation
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit efe208f 🤖
If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Alrighty then! asyncio on Mac and refleaks...
# https://buildbot.python.org/all/#/builders/474/builds/435
test_email leaked [6, 6, 6] memory blocks, sum=18
test_fractions leaked [2, 2, 2] references, sum=6
test_http_cookies leaked [2, 2, 2] references, sum=6
test_property leaked [6, 6, 6] references, sum=18
test_tracemalloc leaked [1, 1, 1] references, sum=3
test_zoneinfo leaked [12, 12, 12] references, sum=36
# https://buildbot.python.org/all/#/builders/18/builds/447
test_email leaked [7, 6, 6] memory blocks, sum=19
test_fractions leaked [2, 2, 2] references, sum=6
test_http_cookies leaked [2, 2, 2] references, sum=6
test_property leaked [6, 6, 6] references, sum=18
test_tracemalloc leaked [1, 1, 1] references, sum=3
test_zoneinfo leaked [12, 12, 12] references, sum=36
+
test_importlib leaked [67, 63, 63] references, sum=193
test_importlib leaked [36, 34, 34] memory blocks, sum=104
# https://buildbot.python.org/all/#/builders/411/builds/436
test_email leaked [6, 6, 6] memory blocks, sum=18
test_fractions leaked [2, 2, 2] references, sum=6
test_http_cookies leaked [2, 2, 2] references, sum=6
test_property leaked [6, 6, 6] references, sum=18
test_tracemalloc leaked [1, 1, 1] references, sum=3
test_zoneinfo leaked [12, 12, 12] references, sum=36
+
test_typing leaked [1, 1, 1] memory blocks, sum=3
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
The asycnio test on Mac seems to be flaky. I've seen a failure on my PRs, which was fixed by re-running the tests.
The refleaks failures are puzzling. Are they passing on main?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
The asycnio test on Mac seems to be flaky. I've seen a failure on my PRs, which was fixed by re-running the tests.
I suspected that but wasn't sure. It failed on repeated CI runs and on that buildbot. So I as at least going to investigate further.
The refleaks failures are puzzling. Are they passing on main?
Hmm, looks like they weren't. So maybe I'm okay here. I'll have to re-run it after the refleaks fix lands.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Hmm, looks like they weren't. So maybe I'm okay here. I'll have to re-run it after the refleaks fix lands.
FYI, they landed with GH-31389 just recently.
|
ericsnowcurrently reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit efe208f 🤖
If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I believe you will need to sync with main first:
$ git fetch --all
$ git merge --no-ff upstream/main
$ git push origin global-objects-use-pyid
|
ericsnowcurrently reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 1852340 🤖
If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
That looks better. I'm still going to double-check that macOS failure before merging.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
sweeneyde
commented
Mar 2, 2022
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
I tested ./python -m test test_decimal -R3:3 and got [1, 1, 1] reference leaks on main, and bisected that to here. Is there some reason why that could happen on my machine but not on buildbots? I tested on windows with MSVC and also on WSL.
1f455361ecfb1892e375bdbee813cdf095b6cfb8 is the first bad commit
commit 1f455361ecfb1892e375bdbee813cdf095b6cfb8
Author: Eric Snow <[email protected]>
Date: Tue Feb 22 17:23:51 2022 -0700
[bpo-46765](https://bugs.python.org/issue46765): Replace Locally Cached Strings with Statically Initialized Objects (gh-31366)
https://bugs.python.org/issue46765
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Running git clean -f ended up fixing everything, so probably nothing to worry about.
|
ericsnowcurrently reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Apr 7, 2022
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|