GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-43723: deprecate camelCase aliases from threading by JelleZijlstra · Pull Request #25174 · python/cpython

Conversation

JelleZijlstra commented Apr 4, 2021 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

The snake_case names have existed since Python 2.6, so there is
no reason to keep the old camelCase names around. One similar
method, threading.Thread.isAlive, was already removed in
Python 3.9 (bpo-37804).

https://bugs.python.org/issue43723

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          bpo-43723: deprecate camelCase aliases from threading

558e66b

The snake_case names have existed since Python 2.6, so there is
no reason to keep the old camelCase names around. One similar
method, threading.Thread.isAlive, was already removed in
Python 3.9 (bpo-37804).

the-knights-who-say-ni added the CLA signed label

Apr 4, 2021

bedevere-bot added the awaiting review label

Apr 4, 2021

vstinner reviewed

Apr 6, 2021

View reviewed changes

Comment thread

Misc/NEWS.d/next/Library/2021-04-03-18-03-44.bpo-43723.uBhBZS.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Misc/NEWS.d/next/Library/2021-04-03-18-03-44.bpo-43723.uBhBZS.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/threading.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/threading.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/threading.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/threading.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra added 2 commits

April 6, 2021 19:55


          don't schedule removal, adjust docs

1af898e


          update tests

a76261a

vstinner reviewed

Apr 7, 2021

View reviewed changes

Comment thread

Doc/library/threading.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/threading.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/threading.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/whatsnew/3.10.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Misc/NEWS.d/next/Library/2021-04-03-18-03-44.bpo-43723.uBhBZS.rst Outdated

Comment on lines +1 to +10

		The following `threading` methods are now deprecated and should be replaced:
		`threading.currentThread` => :func:`threading.current_thread`;
		`threading.activeCount` => :func:`threading.active_count`;
		`threading.Condition.notifyAll` => :meth:`threading.Condition.notify_all`;
		`threading.Event.isSet` => :meth:`threading.Event.is_set`;
		`threading.Thread.setName` => :attr:`threading.Thread.name`;
		`threading.thread.getName` => :attr:`threading.Thread.name`;
		`threading.Thread.isDaemon` => :attr:`threading.Thread.daemon`;
		`threading.Thread.setDaemon` => :attr:`threading.Thread.daemon`.
		Patch by Jelle Zijlstra.

vstinner Apr 7, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	The following `threading` methods are now deprecated and should be replaced:
	`threading.currentThread` => :func:`threading.current_thread`;
	`threading.activeCount` => :func:`threading.active_count`;
	`threading.Condition.notifyAll` => :meth:`threading.Condition.notify_all`;
	`threading.Event.isSet` => :meth:`threading.Event.is_set`;
	`threading.Thread.setName` => :attr:`threading.Thread.name`;
	`threading.thread.getName` => :attr:`threading.Thread.name`;
	`threading.Thread.isDaemon` => :attr:`threading.Thread.daemon`;
	`threading.Thread.setDaemon` => :attr:`threading.Thread.daemon`.
	Patch by Jelle Zijlstra.
	The following `threading` methods are now deprecated and should be replaced:

	* `threading.currentThread` => :func:`threading.current_thread`;
	* `threading.activeCount` => :func:`threading.active_count`;
	* `threading.Condition.notifyAll` => :meth:`threading.Condition.notify_all`;
	* `threading.Event.isSet` => :meth:`threading.Event.is_set`;
	* `threading.Thread.setName` => :attr:`threading.Thread.name`;
	* `threading.thread.getName` => :attr:`threading.Thread.name`;
	* `threading.Thread.isDaemon` => :attr:`threading.Thread.daemon`;
	* `threading.Thread.setDaemon` => :attr:`threading.Thread.daemon`.

	Patch by Jelle Zijlstra.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

JelleZijlstra Apr 8, 2021

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to do it a little differently to get the markup working and work around python/core-workflow#394.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner Apr 8, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to do it a little differently to get the markup working and work around python/core-workflow#394.

If you put each item on a long line, you should not be affected by https://github.com/python/core-workflow/issues/394 no?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

JelleZijlstra Apr 8, 2021

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blurb reflows the lines to make them fit into 76 characters, so I have to make each line fit into 76 characters to avoid the bug.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

JelleZijlstra added 2 commits

April 7, 2021 20:45


          more doc updates

b32c41e


          fix make check

be7c522

vstinner reviewed

Apr 8, 2021

View reviewed changes

Comment thread

Doc/library/threading.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/threading.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/whatsnew/3.10.rst

		* The following ``threading`` methods are now deprecated:

		* ``threading.currentThread`` => :func:`threading.current_thread`

vstinner Apr 8, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't work without these empty lines?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

JelleZijlstra Apr 9, 2021

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, they all get mushed together into a single line

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/library/threading.rst Outdated

		The ``camelCase`` names used for some
		methods and functions in this module in the Python 2.x series are still
		supported by this module.
		supported by this module for compatibility with Python 2.5 and lower.

vstinner Apr 8, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to say "deprecated" somewhere, rather than "still supported".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

JelleZijlstra Apr 9, 2021

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

JelleZijlstra added 2 commits

April 8, 2021 17:49


          reword more docs

8fac027


          fix directives

aeae847

vstinner merged commit 9825bdf into python:master

Apr 12, 2021

bedevere-bot removed the awaiting review label

Apr 12, 2021

vstinner commented Apr 12, 2021

Copy link

Copy Markdown

Member

Thank you @JelleZijlstra for all updates. The final merged change provides very good explanation on the rationale and also great guidance to fix affected. It's really important to provide good guidance on deprecations, to make developers' life easier.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

terryjreedy added a commit to terryjreedy/cpython that referenced this pull request

Apr 16, 2021


          [3.9] bpo-43723: Revert IDLE doc change (pythonGH-25174)

caadcaf

terryjreedy added a commit that referenced this pull request

Apr 16, 2021


          [3.9] bpo-43723: Revert IDLE doc change (GH-25174)

56c76df

Change threading.activeCount to synonym threading.active_count.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Apr 16, 2021


          [3.9] bpo-43723: Revert IDLE doc change (pythonGH-25174)

06d8022

Change threading.activeCount to synonym threading.active_count.
(cherry picked from commit 56c76df)

Co-authored-by: Terry Jan Reedy <[email protected]>

terryjreedy added a commit to terryjreedy/cpython that referenced this pull request

Apr 16, 2021


          [3.8] bpo-43723: Backport IDLE doc change (pythonGH-25174)

3a8a897

Cherry-picked from 9825bdf

terryjreedy commented Apr 16, 2021

Copy link

Copy Markdown

Member

That should have been 'backport', not 'revert' in the titles above. Fixed for 3.8 backport. Sorry for any confusion.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

terryjreedy added a commit that referenced this pull request

Apr 16, 2021


          [3.8] bpo-43723: Backport IDLE doc change (GH-25174)

b405647

Cherry-picked from 9825bdf

vstinner commented Apr 16, 2021

Copy link

Copy Markdown

Member

Thanks for backports @terryjreedy ;-)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington added a commit that referenced this pull request

Apr 16, 2021


          [3.9] bpo-43723: Revert IDLE doc change (GH-25174)

582917f

Change threading.activeCount to synonym threading.active_count.
(cherry picked from commit 56c76df)

Co-authored-by: Terry Jan Reedy <[email protected]>

This was referenced Apr 17, 2021

threading.currentThread has been deprecated in favour of threading.current_thread in Python 3.10 coveragepy/coveragepy#1144

Closed

threading.setDaemon has been deprecated in favor of setting daemon attribute directly in Python 3.10 getsentry/sentry-python#1092

Closed

threading.setDaemon has been deprecated in favor of setting daemon attribute directly in Python 3.10 websocket-client/websocket-client#676

Closed

threading.setDaemon has been deprecated in favor of setting daemon attribute directly in Python 3.10 gitpython-developers/GitPython#1213

Closed

[BUG] threading.Thread.setDaemon has been deprecated in favor of setting daemon attribute directly in Python 3.10 pypa/setuptools#2643

Closed

threading.Thread.setDaemon has been deprecated in favor of setting daemon attribute directly in Python 3.10 rycus86/prometheus_flask_exporter#99

Closed

threading.Thread.setDaemon has been deprecated in favor of setting daemon attribute directly in Python 3.10 dmlc/xgboost#6871

Closed

Joilence mentioned this pull request

Sep 16, 2022

Set daemon attribute directly plotly/kaleido#146

Merged

alexcjohnson pushed a commit to plotly/kaleido that referenced this pull request

Sep 23, 2022


          Set daemon attribute directly (#146)

e274c69

setDaemon() has been deprecated in favor of setting daemon attribute directly in Python 3.10. 

See: python/cpython#25174

Karrenbelt mentioned this pull request

Oct 14, 2022

Chore/recover linters valory-xyz/open-aea#371

Merged

4 of 10 tasks

jupe mentioned this pull request

Oct 17, 2022

use daemon property instead embedded-community/nrf-sniffer-cli#6

Merged

gverm mentioned this pull request

Oct 20, 2022

Set thread daemon attribute directly instead of using setDaemon trela-official/rabbitmq-pika-flask#45

Merged

linrock added a commit to linrock/nnue-pytorch that referenced this pull request

Nov 25, 2022


          Fix warnings about thread.setDaemon() in python 3.10+

cf43859

easy_train.py:316: DeprecationWarning: setDaemon() is deprecated,
set the daemon attribute instead thread.setDaemon(True)

camelCase methods in threading were deprecated in:
python/cpython#25174

linrock mentioned this pull request

Nov 25, 2022

Fix warnings about thread.setDaemon() in python 3.10+ official-stockfish/nnue-pytorch#214

Merged

linrock added a commit to linrock/nnue-pytorch that referenced this pull request

Nov 29, 2022


          Fix warnings about thread.setDaemon() in python 3.10+

4160a7e

easy_train.py:316: DeprecationWarning: setDaemon() is deprecated,
set the daemon attribute instead thread.setDaemon(True)

camelCase methods in threading were deprecated in:
python/cpython#25174

rpurdie pushed a commit to yoctoproject/poky that referenced this pull request

Jan 22, 2023


          bitbake: bitbake: fix deprecated threading.Thread.setDaemon

1c58562

Deprecated in Python 3.10:
https://docs.python.org/3/whatsnew/3.10.html#deprecated
python/cpython#25174

Fixes warnings like:

...bitbake/lib/bb/ui/uievent.py:68: DeprecationWarning: setDaemon() is
deprecated, set the daemon attribute instead
  self.t.setDaemon(True)

(Bitbake rev: ea88be5cb39af86a5bc8a7d151ba65bd12df681f)

Signed-off-by: Tim Orling <[email protected]>
Signed-off-by: Richard Purdie <[email protected]>

halstead pushed a commit to openembedded/bitbake that referenced this pull request

Jan 22, 2023


          bitbake: fix deprecated threading.Thread.setDaemon

ea88be5

Deprecated in Python 3.10:
https://docs.python.org/3/whatsnew/3.10.html#deprecated
python/cpython#25174

Fixes warnings like:

...bitbake/lib/bb/ui/uievent.py:68: DeprecationWarning: setDaemon() is
deprecated, set the daemon attribute instead
  self.t.setDaemon(True)

Signed-off-by: Tim Orling <[email protected]>
Signed-off-by: Richard Purdie <[email protected]>

rpurdie pushed a commit to yoctoproject/poky that referenced this pull request

Jan 23, 2023


          bitbake: bitbake: fix deprecated threading.Thread.setDaemon

2e30849

Deprecated in Python 3.10:
https://docs.python.org/3/whatsnew/3.10.html#deprecated
python/cpython#25174

Fixes warnings like:

...bitbake/lib/bb/ui/uievent.py:68: DeprecationWarning: setDaemon() is
deprecated, set the daemon attribute instead
  self.t.setDaemon(True)

(Bitbake rev: ea88be5cb39af86a5bc8a7d151ba65bd12df681f)

Signed-off-by: Tim Orling <[email protected]>
Signed-off-by: Richard Purdie <[email protected]>

rpurdie pushed a commit to yoctoproject/poky that referenced this pull request

Jan 23, 2023


          bitbake: bitbake: fix deprecated threading.Thread.setDaemon

Deprecated in Python 3.10:
https://docs.python.org/3/whatsnew/3.10.html#deprecated
python/cpython#25174

Fixes warnings like:

...bitbake/lib/bb/ui/uievent.py:68: DeprecationWarning: setDaemon() is
deprecated, set the daemon attribute instead
  self.t.setDaemon(True)

(Bitbake rev: ea88be5cb39af86a5bc8a7d151ba65bd12df681f)

Signed-off-by: Tim Orling <[email protected]>
Signed-off-by: Richard Purdie <[email protected]>

kraj pushed a commit to YoeDistro/poky that referenced this pull request

Jan 24, 2023


          bitbake: bitbake: fix deprecated threading.Thread.setDaemon

bb876d0

Deprecated in Python 3.10:
https://docs.python.org/3/whatsnew/3.10.html#deprecated
python/cpython#25174

Fixes warnings like:

...bitbake/lib/bb/ui/uievent.py:68: DeprecationWarning: setDaemon() is
deprecated, set the daemon attribute instead
  self.t.setDaemon(True)

(Bitbake rev: 17e1b37974ab23a9210a264b0f48dc4812aa75af)

Signed-off-by: Tim Orling <[email protected]>
Signed-off-by: Richard Purdie <[email protected]>
Signed-off-by: Alexandre Belloni <[email protected]>

rpurdie pushed a commit to yoctoproject/poky that referenced this pull request

Jan 24, 2023


          bitbake: bitbake: fix deprecated threading.Thread.setDaemon

4d1675b

Deprecated in Python 3.10:
https://docs.python.org/3/whatsnew/3.10.html#deprecated
python/cpython#25174

Fixes warnings like:

...bitbake/lib/bb/ui/uievent.py:68: DeprecationWarning: setDaemon() is
deprecated, set the daemon attribute instead
  self.t.setDaemon(True)

(Bitbake rev: 323f6ce27a1bfd7159e72f29684674ff495dedee)

Signed-off-by: Tim Orling <[email protected]>
Signed-off-by: Richard Purdie <[email protected]>

halstead pushed a commit to openembedded/bitbake that referenced this pull request

Jan 24, 2023


          bitbake: fix deprecated threading.Thread.setDaemon

323f6ce

Deprecated in Python 3.10:
https://docs.python.org/3/whatsnew/3.10.html#deprecated
python/cpython#25174

Fixes warnings like:

...bitbake/lib/bb/ui/uievent.py:68: DeprecationWarning: setDaemon() is
deprecated, set the daemon attribute instead
  self.t.setDaemon(True)

Signed-off-by: Tim Orling <[email protected]>
Signed-off-by: Richard Purdie <[email protected]>

kraj pushed a commit to YoeDistro/poky that referenced this pull request

Jan 25, 2023


          bitbake: bitbake: fix deprecated threading.Thread.setDaemon

Deprecated in Python 3.10:
https://docs.python.org/3/whatsnew/3.10.html#deprecated
python/cpython#25174

Fixes warnings like:

...bitbake/lib/bb/ui/uievent.py:68: DeprecationWarning: setDaemon() is
deprecated, set the daemon attribute instead
  self.t.setDaemon(True)

(Bitbake rev: 17e1b37974ab23a9210a264b0f48dc4812aa75af)

Signed-off-by: Tim Orling <[email protected]>
Signed-off-by: Richard Purdie <[email protected]>
Signed-off-by: Alexandre Belloni <[email protected]>

evverx added a commit to evverx/scapy that referenced this pull request

Mar 26, 2023


          Use the daemon attribute instead of setDaemon

5e84d12

setDaemon was deprecated in python/cpython#25174

Fixes:
```
>>> test_tls_server("ECDHE-RSA-AES128-SHA", "-tls1")
Traceback (most recent call last):
  File "<input>", line 2, in <module>
  File "<input>", line 9, in test_tls_server
  File "/usr/lib64/python3.11/threading.py", line 1240, in setDaemon
    warnings.warn('setDaemon() is deprecated, set the daemon attribute instead',
DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead
```

gpotter2 pushed a commit to secdev/scapy that referenced this pull request

Mar 26, 2023


          Use the daemon attribute instead of setDaemon

55cc32c

setDaemon was deprecated in python/cpython#25174

Fixes:
```
>>> test_tls_server("ECDHE-RSA-AES128-SHA", "-tls1")
Traceback (most recent call last):
  File "<input>", line 2, in <module>
  File "<input>", line 9, in test_tls_server
  File "/usr/lib64/python3.11/threading.py", line 1240, in setDaemon
    warnings.warn('setDaemon() is deprecated, set the daemon attribute instead',
DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead
```

carlos-villavicencio-adsk mentioned this pull request

Sep 19, 2023

SG-32657 Enable support for Python 3.10 in CI shotgunsoftware/tk-core#920

Merged

6 tasks done

carlos-villavicencio-adsk added a commit to shotgunsoftware/tk-core that referenced this pull request

Sep 25, 2023


          SG-32657 Enable support for Python 3.10 in CI (#920)

509eca8

- Support [deprecation](https://peps.python.org/pep-0632/) of distutils for setuptools > 60.
    - We can't switch to `packaging.version.parse` because many TK components depend of `distutils.version.LooseVersion`. To handle the distutils deprecation, we're switching to the bundled version living on setuptools >= 60. The deprecation warning is still there, so we're suppressing just this one.
- Re-enable commented tests
- Support [deprecation](python/cpython#25174) of `isSet()`
- Upgrade python-api v3.4.0

carlos-villavicencio-adsk mentioned this pull request

Sep 25, 2023

SG-32969 Test CI with Python 3.10 shotgunsoftware/tk-framework-shotgunutils#144

Merged

2 tasks done

AndyTheFactory mentioned this pull request

Oct 24, 2023

threading.Thread.setDaemon has been deprecated in favor of setting daemon attribute directly in Python 3.10 AndyTheFactory/newspaper4k#513

Closed

Bastian-Krause added a commit to Bastian-Krause/pyserial that referenced this pull request

Jan 30, 2024


          treewide: fix remaining uses of threading camel case methods

a6ad55a

The threading camel case methods were deprecated in [1]. A previous
pyserial PR [2] fixed a bunch of these warnings, but missed a few.

Fix the remaining setName() DeprecationWarnings by using the
appropriate name attribute instead.

[1] python/cpython#25174
[2] pyserial#643

Signed-off-by: Bastian Krause <[email protected]>

Bastian-Krause mentioned this pull request

Jan 30, 2024

treewide: fix remaining uses of threading camel case methods pyserial/pyserial#734

Merged

carlsmedstad added a commit to carlsmedstad/pifpaf that referenced this pull request

Aug 16, 2024


          Replace call to deprecated method Thread.setDaemon()

6d88c66

This method was deprecated in Python 3.10, set the Thread.daemon
attribute directly instead.

See: python/cpython#25174

carlsmedstad mentioned this pull request

Aug 16, 2024

Replace call to deprecated method Thread.setDaemon() jd/pifpaf#184

Merged

tobias-urdin pushed a commit to jd/pifpaf that referenced this pull request

Aug 16, 2024


          Replace call to deprecated method Thread.setDaemon() (#184)

213ca69

This method was deprecated in Python 3.10, set the Thread.daemon
attribute directly instead.

See: python/cpython#25174

dpgeorge pushed a commit to pyserial/pyserial that referenced this pull request

Nov 14, 2025


          treewide: fix remaining uses of threading camel case methods

17f8cc3

The threading camel case methods were deprecated in [1]. A previous
pyserial PR [2] fixed a bunch of these warnings, but missed a few.

Fix the remaining setName() DeprecationWarnings by using the
appropriate name attribute instead.

[1] python/cpython#25174
[2] #643

Signed-off-by: Bastian Krause <[email protected]>

fluffy pushed a commit to fluffy/pyserial that referenced this pull request

Dec 19, 2025


          treewide: fix remaining uses of threading camel case methods

947e819

The threading camel case methods were deprecated in [1]. A previous
pyserial PR [2] fixed a bunch of these warnings, but missed a few.

Fix the remaining setName() DeprecationWarnings by using the
appropriate name attribute instead.

[1] python/cpython#25174
[2] pyserial#643

Signed-off-by: Bastian Krause <[email protected]>

hugovk mentioned this pull request

Jul 20, 2026

Formally mark deprecated items in threading for removal in 3.21 #154205

Closed

Reviewers

vstinner

vstinner left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

JelleZijlstra commented Apr 4, 2021 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vstinner commented Apr 12, 2021

Uh oh!

terryjreedy commented Apr 16, 2021

Uh oh!

vstinner commented Apr 16, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JelleZijlstra commented Apr 4, 2021 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.