GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-43962: Fix _PyInterpreterState_IDIncref() (GH-25683) by miss-islington · Pull Request #25685 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Apr 28, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

_PyInterpreterState_IDIncref() now calls
_PyInterpreterState_IDInitref() and always increments id_refcount.
(cherry picked from commit 32c5a17)

Co-authored-by: Victor Stinner [email protected]

https://bugs.python.org/issue43962

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner @miss-islington
bpo-43962: Fix _PyInterpreterState_IDIncref() (pythonGH-25683)
6de3080 
_PyInterpreterState_IDIncref() now calls
_PyInterpreterState_IDInitref() and always increments id_refcount.
(cherry picked from commit 32c5a17)

Co-authored-by: Victor Stinner <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 28, 2021
@bedevere-bot bedevere-bot mentioned this pull request Apr 28, 2021
bpo-43962: Fix _PyInterpreterState_IDIncref() #25683
Merged
@miss-islington

miss-islington commented Apr 28, 2021

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Apr 28, 2021
@miss-islington

miss-islington commented Apr 28, 2021

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Apr 28, 2021

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Apr 28, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 28, 2021
pablogsal
pablogsal requested changes Apr 28, 2021
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, regenerate the ABI

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot

bedevere-bot commented Apr 28, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting merge labels Apr 28, 2021
@miss-islington

miss-islington commented Apr 28, 2021

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Apr 28, 2021

Copy link
Copy Markdown
Member

@pablogsal:

Please, regenerate the ABI

I don't know how to do that: https://bugs.python.org/issue43725#msg392205
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Apr 28, 2021

Copy link
Copy Markdown
Member

I don't know how to do that: https://bugs.python.org/issue43725#msg392205

Check out the same docker container the CI uses and run the make regen-abidump target.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented May 29, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 29, 2021
@vstinner

vstinner commented Oct 15, 2021

Copy link
Copy Markdown
Member

Check out the same docker container the CI uses

I don't know how to do that: https://bugs.python.org/issue43725#msg404019

Maybe I should just abandon this backport.

It's a little bit annoying of not being able to backport a fix because the CI says that it breaks the ABI, whereas the modified function is only part of the internal C API and its name starts with "_Py", so it's a private function.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jan 23, 2022

Copy link
Copy Markdown
Member

I still don't know how to update the ABI. So I just abandon my bugfix backport, sorry.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Jan 23, 2022
@miss-islington
miss-islington deleted the backport-32c5a17-3.9 branch January 23, 2022 01:01
@vstinner vstinner mentioned this pull request May 22, 2022
test_interpreters: when TestInterpreterAttrs.test_id_type() is run alone, it fails with an assertion error #88128
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal requested changes
@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @bedevere-bot @vstinner @pablogsal @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.