GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43962: Fix _PyInterpreterState_IDIncref() by vstinner · Pull Request #25683 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Apr 28, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

_PyInterpreterState_IDIncref() now calls
_PyInterpreterState_IDInitref() and always increments id_refcount.

https://bugs.python.org/issue43962

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-43962: Fix _PyInterpreterState_IDIncref()
968ffa4 
_PyInterpreterState_IDIncref() now calls
_PyInterpreterState_IDInitref() and always increments id_refcount.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 28, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Apr 28, 2021
@vstinner
vstinner merged commit 32c5a17 into python:master Apr 28, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 28, 2021
@vstinner vstinner added the needs backport to 3.9 label Apr 28, 2021
@miss-islington

miss-islington commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the fix_interpid_race branch April 28, 2021 11:40
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 28, 2021
@vstinner @miss-islington
bpo-43962: Fix _PyInterpreterState_IDIncref() (pythonGH-25683)
6de3080 
_PyInterpreterState_IDIncref() now calls
_PyInterpreterState_IDInitref() and always increments id_refcount.
(cherry picked from commit 32c5a17)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Apr 28, 2021
@bedevere-bot

bedevere-bot commented Apr 28, 2021

Copy link
Copy Markdown

GH-25685 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added a commit that referenced this pull request Apr 28, 2021
@vstinner
bpo-43962: Fix _PyInterpreterState_IDIncref() (GH-25683) (GH-25686)
77db337 
_PyInterpreterState_IDIncref() now calls
_PyInterpreterState_IDInitref() and always increments id_refcount.

(cherry picked from commit 32c5a17)
corona10 pushed a commit to corona10/cpython that referenced this pull request Jun 4, 2021
@vstinner @corona10
[3.9] bpo-43962: Fix _PyInterpreterState_IDIncref() (pythonGH-25683)
fe0958c 
_PyInterpreterState_IDIncref() now calls
_PyInterpreterState_IDInitref() and always increments id_refcount.
(cherry picked from commit 32c5a17)

Co-authored-by: Victor Stinner <[email protected]>
@vstinner vstinner mentioned this pull request May 22, 2022
test_interpreters: when TestInterpreterAttrs.test_id_type() is run alone, it fails with an assertion error #88128
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.