GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43795 - Update Stable ABI dat. by orsenthil · Pull Request #25716 · python/cpython

Conversation

@orsenthil

@orsenthil orsenthil commented Apr 29, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PRs were failing with the check if generated files are up to date. For e.g this one.

The Stable ABI was updated here in this PR - #25315
The change in this diff was introduced here - 3cc481b

I had run make regen-limited-abi to recrete the stable abi manifest.

https://bugs.python.org/issue43774

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@orsenthil
Update Stable ABI dat.
ce8f6bc
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 29, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Apr 29, 2021
@orsenthil orsenthil changed the title Update Stable ABI dat. bpo-43774 - Update Stable ABI dat. Apr 29, 2021
@orsenthil
orsenthil requested review from serhiy-storchaka and vstinner April 29, 2021 11:26
orsenthil
orsenthil commented Apr 29, 2021
View reviewed changes
Comment thread Doc/data/stable_abi.dat
PyFrozenSet_New
PyFrozenSet_Type
PyGC_Collect
PyGC_Disable

@orsenthil orsenthil Apr 29, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right to me and don't know how to read this.

This was the output of make regen-limited-abi

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@orsenthil orsenthil Apr 29, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@encukou - Please verify if this is correct.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@scoder scoder Apr 29, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's not correct. Those should stay in the file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@scoder scoder Apr 29, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They probably need to get added to Misc/stable_abi.txt now. That seems to be the new source of truth. I'll add them there.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@orsenthil orsenthil Apr 29, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scoder - Thank you. I could update this PR with Misc/stable_abi.txt change too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@orsenthil orsenthil Apr 29, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petr took care of it - #25720

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@orsenthil
orsenthil requested a review from encukou April 29, 2021 11:57
@orsenthil orsenthil changed the title bpo-43774 - Update Stable ABI dat. bpo-43795 - Update Stable ABI dat. Apr 29, 2021
@orsenthil orsenthil mentioned this pull request Apr 29, 2021
bpo-43882 - urllib.parse should sanitize urls containing ASCII newline and tabs. #25595
Merged
@orsenthil
orsenthil requested a review from scoder April 29, 2021 12:49
@markshannon markshannon mentioned this pull request Apr 29, 2021
bpo-28254: Add a C-API for controlling the state of the garbage collector #25687
Merged
@encukou

encukou commented Apr 29, 2021

Copy link
Copy Markdown
Member

Oh, these are new symbols that got in as I merged PEP 652 commit. Sorry for the mismatch; I'll add them.
Details are in PEP 652, while I'm finishing up proper docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orsenthil

orsenthil commented Apr 29, 2021

Copy link
Copy Markdown
Member Author

Updating this PR at the correct location.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Apr 29, 2021

Copy link
Copy Markdown
Member

See GH-25720
orsenthil reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orsenthil

orsenthil commented Apr 29, 2021

Copy link
Copy Markdown
Member Author

Thank you. This is resolved by #25720
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orsenthil orsenthil closed this Apr 29, 2021
@orsenthil
orsenthil deleted the abi_fix branch April 29, 2021 16:04
@encukou encukou mentioned this pull request Jun 7, 2022
Implement PEP 652 -- Maintaining the Stable ABI #87961
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka
@encukou encukou Awaiting requested review from encukou
@scoder scoder Awaiting requested review from scoder

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@orsenthil @encukou @scoder @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.