GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-28254: Add PyGC_ functions to the stable ABI manifest by encukou · Pull Request #25720 · python/cpython

Conversation

@encukou

@encukou encukou commented Apr 29, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I've just merged the "stable ABI manifest" part of PEP-652, so checks fail since 3 new functions were added to the stable ABI.

  • add them to Misc/stable_abi.txt
  • regenerate files (make regen-limited-abi)

https://bugs.python.org/issue28254

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
bpo-28254: Add PyGC_ functions to the stable ABI manifest
584e13c
@encukou
encukou requested a review from a team as a code owner April 29, 2021 13:19
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 29, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Apr 29, 2021
@encukou encukou mentioned this pull request Apr 29, 2021
bpo-43795 - Update Stable ABI dat. #25716
Closed
@encukou encukou added the skip news label Apr 29, 2021
orsenthil
orsenthil reviewed Apr 29, 2021
View reviewed changes
Comment thread Misc/stable_abi.txt
# (Detailed comments aren't really needed for further entries: from here on
# we can use version control logs.)

function PyGC_Disable

@orsenthil orsenthil Apr 29, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Shouldn't these at line 2124.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
orsenthil
orsenthil approved these changes Apr 29, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 29, 2021
scoder
scoder reviewed Apr 29, 2021
View reviewed changes
Comment thread Misc/stable_abi.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes Apr 29, 2021
View reviewed changes
scoder
scoder approved these changes Apr 29, 2021
View reviewed changes
@pablogsal pablogsal mentioned this pull request Apr 29, 2021
bpo-28254: Add a C-API for controlling the state of the garbage collector #25687
Merged
@encukou @scoder
Update Misc/stable_abi.txt
958ac66 
Co-authored-by: scoder <[email protected]>
@orsenthil orsenthil mentioned this pull request Apr 29, 2021
bpo-43882 - urllib.parse should sanitize urls containing ASCII newline and tabs. #25595
Merged
@encukou
encukou merged commit 14fc2bd into python:master Apr 29, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 29, 2021
@encukou
encukou deleted the bpo-28254-abi branch April 29, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orsenthil orsenthil orsenthil approved these changes
@scoder scoder scoder approved these changes
@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@encukou @orsenthil @scoder @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.