GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43901: Upgrade test to use cool module reloading tech. by larryhastings · Pull Request #25752 · python/cpython

Conversation

@larryhastings

@larryhastings larryhastings commented Apr 30, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

One of my new tests is broken on the Windows buildbot. Pablo suggested I modify the test to use import_helper.import_fresh_module(), so... here goes!

https://bugs.python.org/issue43901

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@larryhastings
Upgrade test to use cool module reloading tech.
4b6e099
@bedevere-bot bedevere-bot added the awaiting core review label Apr 30, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 30, 2021
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Apr 30, 2021
@pablogsal

pablogsal commented Apr 30, 2021

Copy link
Copy Markdown
Member

I opened #25754 to tacke this + the refleaks.

Could you review it?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@larryhastings larryhastings closed this Apr 30, 2021
@larryhastings
larryhastings deleted the fix_buildbots_tests branch April 30, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@larryhastings @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.