GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — bpo-43901: Fix refleaks in test_module by pablogsal · Pull Request #25754 · python/cpython Conversation
|
|
I'm still missing another leak: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Gotcha! I have it fixed in 3640843 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ok, we are clean: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I was about to make my PR ;-) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, I was doing this patch and missed your comments on BPO :( |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It's hard to see how that code could ever have passed a refleak check! It seems like would always have leaked that dict. Yet I swear I ran one! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@larryhastings If you already have the PR made I can close this one and we can merge yours if you prefer :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I don't mind the parallel effort, as long as it gets fixed one way or another. I've caused enough headaches and gnashing of teeth this week--let's try and keep this incident to a minimum! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Let's go with yours, the PR is already up and checks are running. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
No problem Larry! This happens quite a lot for everyone, and the important thing is that we have your patch for 3.10 :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
What rot! This never happened during the release process for 3.4 and 3.5! Nobody ever broke the build, ever. I'm clearly a tiresome outlier. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.