GeezerVison is showing github.com — bpo-40465: Remove random module features deprecated in 3.9 by rhettinger · Pull Request #25874 · python/cpython
Conversation
rhettinger
commented
May 4, 2021
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
agateau-gg
added a commit
to agateau-gg/rstr
that referenced
this pull request
Jul 3, 2023
This code:
```python
from rstr import Rstr
from random import SystemRandom
Rstr(SystemRandom())
```
Fails to pass pyright tests. `_Random.shuffle()` expects two arguments,
one optional, but since Python 3.11 `Random.shuffle()` only takes one
argument.
No need to add version-specific code: the new version works OK with
Python < 3.11.
Ref: python/cpython#25874
agateau-gg
added a commit
to agateau-gg/rstr
that referenced
this pull request
Jul 5, 2023
This code:
```python
from rstr import Rstr
from random import SystemRandom
Rstr(SystemRandom())
```
Fails to pass pyright tests. `_Random.shuffle()` expects two arguments,
one optional, but since Python 3.11 `Random.shuffle()` only takes one
argument (see python/cpython#25874).
typeshed includes a stub for Random, so it's now possible to use it
directly instead of maintaining a custom stub for it.
agateau-gg
added a commit
to agateau-gg/rstr
that referenced
this pull request
Jul 6, 2023
This code:
```python
from rstr import Rstr
from random import SystemRandom
Rstr(SystemRandom())
```
Fails to pass pyright tests. `_Random.shuffle()` expects two arguments,
one optional, but since Python 3.11 `Random.shuffle()` only takes one
argument (see python/cpython#25874).
typeshed includes a stub for Random, so it's now possible to use it
directly instead of maintaining a custom stub for it.
|
|
'supported seed types are: None, '
|
|
|
'int, float, str, bytes, and bytearray.',
|
|
|
DeprecationWarning, 2)
|
|
|
raise TypeError('The only supported seed types are: None,\n'
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the newline in the middle of the error message intentional? It reads awkward to the user.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
+1 more reviewer
yilei
yilei left review comments
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|