Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:

1. Sign the PSF contributor agreement
2. Wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
3. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

Thanks for working on this. Doc changes are also needed.

As well as tests for the deprecation message.

Somehow I hadn't noticed that 'monetary' wasn't supported by format_string. So that is actually an enhancement, in addition to the deprecation, and needs to be documented as such (versionchanged, whats new entry). Also, format itself shouldn't be changed, just deprecated (that is, the deprecation message code added, but nothing else in it changed).

@bitdancer I don't think to keep locale.format as it is and just displaying deprecated warning would be of any use. I think it is safe to call locale.format_string internally.

That's the way we normally do deprecations: leave the existing code in place (so its behavior doesn't change) but point people to the preferred solution. It would be acceptable if there were no behavior changes, but the changed tests prove that there are.

Codecov Report

Merging #259 into master will decrease coverage by -1.01%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   83.38%   82.38%   -1.01%     
==========================================
  Files        1367     1428      +61     
  Lines      344897   351221    +6324     
==========================================
+ Hits       287596   289342    +1746     
- Misses      57301    61879    +4578

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae160bb...6097e47. Read the comment docs.

@bitdancer is it good to go now?

Yes, I think so. I'd like to do a final overall review before I approve it, though. With any luck I'll do that tonight.

Thanks! :)

Hey, @bitdancer have you reviewed this?

I did...and I feel bad that I have some more changes to suggest, so I was going to make them myself and submit it to the PR, but I haven't actually figured out how to do that yet.

@bitdancer well I think you can suggest me the changes I'll do my best to figure them out.

There was no need to move format in the source file, but it doesn't hurt, either.

Hey @bitdancer is there anything left to get this merged?

Just adding the Misc/NEWS entry. I'm not sure what status is on how to do that currently, but I think it is still manual edit of that file. I haven't had time yet to learn how to update a PR before merge, so if you add the entry, I'll hit merge :)