GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40943: Fix skipitem() didn't raise SystemError by methane · Pull Request #25937 · python/cpython

Conversation

@methane

@methane methane commented May 6, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

convertitem() raises SystemError when '#' is used without PY_SSIZE_T_CLEAN defined.
skipitem() should do it too.

https://bugs.python.org/issue40943

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane
bpo-40943: Fix skipitem() didn't raise SystemError
bd8d2f7 
convertitem() raises SystemError when # is used PY_SSIZE_T_CLEAN.
skipitem() should too.
@methane
methane requested review from serhiy-storchaka and vstinner May 6, 2021 09:03
@bedevere-bot bedevere-bot added the awaiting core review label May 6, 2021
@methane methane added the needs backport to 3.10 label May 6, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 6, 2021
@methane methane added skip news type-bug An unexpected behavior, bug, or error and removed CLA signed labels May 6, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 6, 2021
serhiy-storchaka
serhiy-storchaka approved these changes May 6, 2021
View reviewed changes
Comment thread Python/getargs.c
return NULL;
}
(void) va_arg(*p_va, int *);
PyErr_SetString(PyExc_SystemError,

@serhiy-storchaka serhiy-storchaka May 6, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rewrite this code in the form:

if (!(flags & FLAG_SIZE_T)) {
    ...
}
(void) va_arg(*p_va, Py_ssize_t *);

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 6, 2021
@methane
Apply suggested change.
a54b542
@methane
methane merged commit 4ebf4a6 into python:main May 7, 2021
@methane
methane deleted the fix-skipitem branch May 7, 2021 02:56
@miss-islington

miss-islington commented May 7, 2021

Copy link
Copy Markdown
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 7, 2021
@bedevere-bot

bedevere-bot commented May 7, 2021

Copy link
Copy Markdown

GH-25961 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label May 7, 2021
miss-islington added a commit that referenced this pull request May 7, 2021
@miss-islington @methane
bpo-40943: Fix skipitem() didn't raise SystemError (GH-25937)
569ca81 
`convertitem()` raises `SystemError` when 'GH-' is used without `PY_SSIZE_T_CLEAN`.
This commit makes `skipitem()` raise it too.
(cherry picked from commit 4ebf4a6)

Co-authored-by: Inada Naoki <[email protected]>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@jlchang jlchang mentioned this pull request Mar 31, 2023
Restore missing symlink to python in docker image (SCP-4547) broadinstitute/scp-ingest-pipeline#299
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@methane @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.